From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 642264BE39 for ; Wed, 17 Jul 2024 06:47:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A64EC68DA65; Wed, 17 Jul 2024 09:47:54 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC91A68D8E1 for ; Wed, 17 Jul 2024 09:47:47 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=HO34x0Fq; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 58535240DB7 for ; Wed, 17 Jul 2024 08:47:47 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id WUlb1RiS7fqU for ; Wed, 17 Jul 2024 08:47:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721198865; bh=6fsqA/CC2ih5TAmcLuz1an7qpPe9xIZZU1dDWOR9TPs=; h=Subject:From:To:In-Reply-To:References:Date:From; b=HO34x0FqLD7HZ285TXwJsg6qPNULmDp47c5I0FyC3VLjppbpwhPy6NWp0AtzJS4qI Q1wDIdKpDU/C3xreJ86Dgn/EuDxYVi8bngoYBDgVnb13tqOwjaZU9/0ZAH3ikaQNEB I5jNswpFpaQR9oAvBTdjsDb7EHHCjKFFwE0tMsRLFASJVzf5oYv/t4oJzjVeUuCvtB 95rek4U7q5aNeGQ6LFp2dOdyLucKR226a5oEwFI6kNgvyWftgDvurjQNIx+s2iGQk5 oTI8Gi2MEUvEjWBl/qrFbD7jzJ2DOguKruqkNrm6vFg0pAK236MvnH9qK6pay33Ks4 8Q+ashfPTFx9w== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 31F56240695 for ; Wed, 17 Jul 2024 08:47:45 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0C9D71601B9; Wed, 17 Jul 2024 08:47:45 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240711094937.696960-1-michael@niedermayer.cc> References: <20240711094937.696960-1-michael@niedermayer.cc> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 17 Jul 2024 08:47:45 +0200 Message-ID: <172119886502.21847.9874785919727246540@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/avio: avio_tell() only errors if the context is NULL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-07-11 11:49:37) > Found by code review related to coverity > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/avio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/avio.h b/libavformat/avio.h > index ebf611187dc..3be91e4b8a7 100644 > --- a/libavformat/avio.h > +++ b/libavformat/avio.h > @@ -489,7 +489,7 @@ int64_t avio_skip(AVIOContext *s, int64_t offset); > > /** > * ftell() equivalent for AVIOContext. > - * @return position or AVERROR. > + * @return position or AVERROR in case s is NULL. It seems weird to document an invalid call. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".