From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 99C23476CA for ; Wed, 17 Jul 2024 06:18:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B31F68D9D8; Wed, 17 Jul 2024 09:18:22 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 31C1968D8A2 for ; Wed, 17 Jul 2024 09:18:15 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=qx08567q; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9FB51240DB7 for ; Wed, 17 Jul 2024 08:18:14 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id LivZwqe-QiN0 for ; Wed, 17 Jul 2024 08:18:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721197094; bh=4WY14xhwriLJTkPvuVY3P0sNgaKVDwib6zlPkNxP6N8=; h=Subject:From:To:In-Reply-To:References:Date:From; b=qx08567qsc+sycWL8IuAJGSoqu8cE2Y18Ky22AzByXHR4kXJ5NIomrEeNhkw601+1 z3yt3YAtYZ09nK+M5sgF/sA3bvShD3VzFT1l1yZ/oTDbwncqBQYXJ63V2bCca8tEc/ /JhUnoyuiO9zPYsRXBVoxDb/pN6MLvR4gVGyT5Q2Qnb1ryK/ueHSeitACyk9USLpQj bQrCWyXwdqJqDDgEaBNcBpVYv+T3iaWmNb39gx2+qHkEaOR+NWNVI9IphhVVm4Wzbo RUQzCGtZH8iRzwtBGM5zaerbaMe21EKGWuBvoBnfRRAYxh3IukR0qogjQ90Ajw7mEg UoyFNlwUc2kKQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 19AEC240695 for ; Wed, 17 Jul 2024 08:18:14 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id F264A1601B9; Wed, 17 Jul 2024 08:18:07 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240717014925.16517-1-jamrial@gmail.com> References: <20240717014925.16517-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 17 Jul 2024 08:18:07 +0200 Message-ID: <172119708795.21847.6585401142014653610@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/4] avformat/movenc: fix channel count and samplerate fields for IAMF tracks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-07-17 03:49:22) > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 2bea55e33d..5de188f4cf 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -1399,6 +1399,11 @@ static int mov_write_audio_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex > avio_wb16(pb, 16); > avio_wb16(pb, track->audio_vbr ? -2 : 0); /* compression ID */ > } else { /* reserved for mp4/3gp */ > +#if CONFIG_IAMFENC > + if (track->tag == MKTAG('i','a','m','f')) > + avio_wb16(pb, 0); /* channelcount must be 0 for IAMF */ > + else > +#endif > avio_wb16(pb, track->par->ch_layout.nb_channels); avio_wb16(pb, track->tag == MKTAG('i', 'a', 'm', 'f') ? 0 : track->par->ch_layout.nb_channels); looks more readable to me -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".