Re: [FFmpeg-devel] [PATCH 1/4] avformat/movenc: fix channel count and samplerate fields for IAMF tracks

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avformat/movenc: fix channel count and samplerate fields for IAMF tracks
Date: Wed, 17 Jul 2024 08:18:07 +0200
Message-ID: <172119708795.21847.6585401142014653610@lain.khirnov.net> (raw)
In-Reply-To: <20240717014925.16517-1-jamrial@gmail.com>

Quoting James Almer (2024-07-17 03:49:22)
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 2bea55e33d..5de188f4cf 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -1399,6 +1399,11 @@ static int mov_write_audio_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex
>                  avio_wb16(pb, 16);
>              avio_wb16(pb, track->audio_vbr ? -2 : 0); /* compression ID */
>          } else { /* reserved for mp4/3gp */
> +#if CONFIG_IAMFENC
> +            if (track->tag == MKTAG('i','a','m','f'))
> +                avio_wb16(pb, 0); /* channelcount must be 0 for IAMF */
> +            else
> +#endif
>              avio_wb16(pb, track->par->ch_layout.nb_channels);

avio_wb16(pb, track->tag == MKTAG('i', 'a', 'm', 'f') ?
              0 : track->par->ch_layout.nb_channels);

looks more readable to me

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".