From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum
Date: Sat, 13 Jul 2024 15:47:33 +0200
Message-ID: <172087845360.21847.8260743025610001929@lain.khirnov.net> (raw)
In-Reply-To: <20240712003307.64005-2-jamrial@gmail.com>
Quoting James Almer (2024-07-12 02:33:07)
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavcodec/bsf/showinfo.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/bsf/showinfo.c b/libavcodec/bsf/showinfo.c
> index 0899263545..57da3fc73c 100644
> --- a/libavcodec/bsf/showinfo.c
> +++ b/libavcodec/bsf/showinfo.c
> @@ -23,6 +23,7 @@
> #include "bsf.h"
> #include "bsf_internal.h"
>
> +#include "libavutil/adler32.h"
> #include "libavutil/internal.h"
> #include "libavutil/log.h"
> #include "libavutil/timestamp.h"
> @@ -34,22 +35,25 @@ typedef struct ShowinfoContext {
> static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
> {
> ShowinfoContext *priv = ctx->priv_data;
> + uint32_t crc;
> int ret;
>
> ret = ff_bsf_get_packet_ref(ctx, pkt);
> if (ret < 0)
> return ret;
>
> + crc = av_adler32_update(0, pkt->data, pkt->size);
> av_log(ctx, AV_LOG_INFO,
> "n:%7"PRIu64" "
> "size:%7d "
> "pts:%s pt:%s "
> "dts:%s dt:%s "
> "ds:%"PRId64" d:%s "
> + "0x%08"PRIx32,
could you prefix it with checksum: or something, so it's clear what it
means?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-13 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 0:33 [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags James Almer
2024-07-12 0:33 ` [FFmpeg-devel] [PATCH 2/2] avcodec/bsf/showinfo: print packet data checksum James Almer
2024-07-13 13:47 ` Anton Khirnov [this message]
2024-07-13 14:05 ` [FFmpeg-devel] [PATCH v2] " James Almer
2024-07-13 14:36 ` Anton Khirnov
2024-07-13 13:46 ` [FFmpeg-devel] [PATCH 1/2] avcodec/bsf/showinfo: print packet side data and flags Anton Khirnov
2024-07-13 13:49 ` James Almer
2024-07-13 14:04 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172087845360.21847.8260743025610001929@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git