Re: [FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: add a new mechanism to expose used queue families

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: add a new mechanism to expose used queue families
Date: Tue, 09 Jul 2024 08:57:33 +0200
Message-ID: <172050825390.21847.1255531124935548598@lain.khirnov.net> (raw)
In-Reply-To: <20240709010719.914497-1-dev@lynne.ee>

Quoting Lynne via ffmpeg-devel (2024-07-09 03:07:12)
> @@ -151,6 +162,17 @@ typedef struct AVVulkanDeviceContext {
>       * Similar to lock_queue(), unlocks a queue. Must only be called after locking.
>       */
>      void (*unlock_queue)(struct AVHWDeviceContext *ctx, uint32_t queue_family, uint32_t index);
> +
> +    /**
> +     * Queue families used. Must be preferentially ordered. List may contain
> +     * duplicates, as long as their capability flags do not match.
> +     *
> +     * For compatibility reasons, all the enabled queue families listed above
> +     * (queue_family_(tx/comp/encode/decode)_index) must also be included in
> +     * this list until they're removed after deprecation.
> +     */
> +    AVVulkanDeviceQueueFamily qf[16];

Why 16? And are we really really sure sizeof(AVVulkanDeviceQueueFamily)
should be a part of the ABI?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".