From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 13BDD4B9A3 for ; Tue, 2 Jul 2024 19:00:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8485868D904; Tue, 2 Jul 2024 22:00:23 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C5E4B68D37C for ; Tue, 2 Jul 2024 22:00:17 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=XS4pmGCH; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 841C5240DAC for ; Tue, 2 Jul 2024 21:00:17 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id oaHrPkuDOkUO for ; Tue, 2 Jul 2024 21:00:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719946816; bh=jkVFa5S37wGb3+ZCjrFTeP7w+jsUrKrq36acG9Z4qQM=; h=Subject:From:To:In-Reply-To:References:Date:From; b=XS4pmGCH/FjCJ08Wf8m4lFHQmnG0sgh5gmuz41HeTKLvMEj6hREWh7nhXLQxPlIdz qvnSDV+InBFInGQEgvv3uyvd/A9ayF3QScbOWb+YKxu+6Re0Qu0jAawTSXz7cj7y8k /YSuSiAsZ1uivan6jJmMwAv2D2VvOZZe86f+iWCBjNfHXvJCIBnT0zOzKIJieYF220 0KjBfqnMSAlgeWD9SRnqC7/Vo75INoP2mammW3DNZ1u25Vs4KVRgdjKBFDUkp5pRs5 SdZTwcwuXWrNDLvlapzngF6OiXkolo38TWRGcfwj+jFMNtvFLeglskqobTPEfJOx5x cVCXHWq1AfF4A== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id C82792404E5 for ; Tue, 2 Jul 2024 21:00:16 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id A3BC51601B9; Tue, 2 Jul 2024 21:00:16 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <102189ef-09b2-4988-8a50-ffcb05d7d158@gmail.com> References: <171931078242.21847.5755059493417163903@lain.khirnov.net> <20240702164936.6140-1-jamrial@gmail.com> <171994291944.21847.1436706415867340803@lain.khirnov.net> <102189ef-09b2-4988-8a50-ffcb05d7d158@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 02 Jul 2024 21:00:16 +0200 Message-ID: <171994681664.21847.2170158755006205573@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/6 v3] fftools/ffmpeg: support applying container level cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-07-02 20:43:59) > On 7/2/2024 2:55 PM, Anton Khirnov wrote: > >> + > >> +@table @option > >> +@item none (0) > >> +Don't apply any cropping metadata. > >> +@item all (1) > >> +Apply both codec and container level croppping. This is the default mode. > >> +@item codec (2) > >> +Apply codec level croppping. > >> +@item container (3) > >> +Apply container level croppping. > >> + > >> +@end table > >> + > > > > Also, this should probably be in the advanced section, since it's marked > > as OPT_EXPERT. > > So are autoscale and autorotate, which are also outside the advanced > section. But i can move it if you prefer. Please do. Patch ok otherwise. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".