From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0903648B34 for ; Tue, 2 Jul 2024 17:55:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DBB1D68D92D; Tue, 2 Jul 2024 20:55:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D82B768D8A0 for ; Tue, 2 Jul 2024 20:55:20 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=p9xIWTXh; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 831C0240DAC for ; Tue, 2 Jul 2024 19:55:20 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id c7_tWEyGIaBz for ; Tue, 2 Jul 2024 19:55:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719942919; bh=t5Iy82DpIsjuqOuMg4bN6L9QOkUzwaIRral11XgXLDA=; h=Subject:From:To:In-Reply-To:References:Date:From; b=p9xIWTXhr5WdwvsAXCsqddqrpMKSTVgkD1fn+H/od42Yw794YECnkJmgiI7jh8NgP CuDmJy+YYa+Z6lWDsVO6hwQ3vpSlfIP28UdQaVPWE6dMh72b+Bwo0xf0vf+BUMqWvg zW8G7vRFkX0245A8JfEprkafeLY+FsW7yLZB3gT1Y1B5qfzf24ZiUY4MLfC6UbEDzT Mca+dJ7skU3dtWtWVguP86GA5NMiPwytvK5wCV5qFytyNr6H5ghj7RmSqYi7mkgBUt rnNy2RG1WBCHmfGOh4LKEWRFfkF2XP9QrAw/4zjjqqIpaY9eeSYj6hNlSdATXw3y42 Rs3sgj53U4wcw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9AD072404E5 for ; Tue, 2 Jul 2024 19:55:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 74DFC1601B9; Tue, 2 Jul 2024 19:55:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240702164936.6140-1-jamrial@gmail.com> References: <171931078242.21847.5755059493417163903@lain.khirnov.net> <20240702164936.6140-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 02 Jul 2024 19:55:19 +0200 Message-ID: <171994291944.21847.1436706415867340803@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/6 v3] fftools/ffmpeg: support applying container level cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-07-02 18:49:36) > Signed-off-by: James Almer > --- > doc/ffmpeg.texi | 16 ++++++++++++++++ > fftools/ffmpeg.h | 15 +++++++++++++++ > fftools/ffmpeg_demux.c | 26 ++++++++++++++++++++++++++ > fftools/ffmpeg_filter.c | 10 ++++++++++ > fftools/ffmpeg_opt.c | 25 +++++++++++++++++++++++++ > 5 files changed, 92 insertions(+) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index f25f6192eb..f75ed681cf 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi > @@ -1262,6 +1262,22 @@ disabled, all output frames of filter graph might not be in the same resolution > and may be inadequate for some encoder/muxer. Therefore, it is not recommended > to disable it unless you really know what you are doing. > Disable autoscale at your own risk. > + > +@item -apply_cropping +@item -apply_cropping[:@var{stream_specifier}] @var{source} (@emph{input,per-stream}) > +Automatically crop the video according to file metadata. Default is @emph{all}. ^ after decoding > + > +@table @option > +@item none (0) > +Don't apply any cropping metadata. > +@item all (1) > +Apply both codec and container level croppping. This is the default mode. > +@item codec (2) > +Apply codec level croppping. > +@item container (3) > +Apply container level croppping. > + > +@end table > + Also, this should probably be in the advanced section, since it's marked as OPT_EXPERT. > @@ -715,6 +729,7 @@ AVDictionary *strip_specifiers(const AVDictionary *dict); > int find_codec(void *logctx, const char *name, > enum AVMediaType type, int encoder, const AVCodec **codec); > int parse_and_set_vsync(const char *arg, int *vsync_var, int file_idx, int st_idx, int is_global); > +int parse_and_set_cropping(const char *arg, int *out); What's the point of this being in a separate file when it's only used from ffmpeg_demux? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".