From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A822D45D6F for ; Tue, 2 Jul 2024 09:37:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7596568D8DB; Tue, 2 Jul 2024 12:37:55 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C3DD768D54C for ; Tue, 2 Jul 2024 12:37:49 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=OK1CzY+K; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 86234240DAC for ; Tue, 2 Jul 2024 11:37:49 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id CvytNmEPikGr for ; Tue, 2 Jul 2024 11:37:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719913068; bh=G1D1ZPPVO7ywx6mWzcjrwRiVl6AUvmV/j2YzCgmotFE=; h=Subject:From:To:In-Reply-To:References:Date:From; b=OK1CzY+K1hdD4DD7xPehZnfWP3wdxmZa4tji97bB12/gkpJgY5CxFvLljzMZM8SLO I3h0M+5+ASgW5iYA/oT48f3xiUgleUUj4GwjeM0JPVTLY970r+rfmdLUlw1UgijpjB O2DrGezcCSnBz0SCGJS0LiigBzOyibSsaK8sSBU3ADWGjV34KVGmWba3QTdPfMNJNF NBbjaKpdx5IuPwwic2BYvHIdSSNQUH0Z6HnHnk0TYLojd1wEbqbIt7rRZ6qAcNjIgQ LwYyJ2wNLGo0Pri9NNzP2RQRywDFPuaJCGOMEz5xsFJNjzJp/L9jURgDl357HXhnO+ 4jftoPnxOghjw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id A793C2404E5 for ; Tue, 2 Jul 2024 11:37:48 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 93CC31601B9; Tue, 2 Jul 2024 11:37:48 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240329083509.10130-1-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 02 Jul 2024 11:37:48 +0200 Message-ID: <171991306857.21847.17425905695975657583@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-30 13:49:07) > On 3/29/2024 5:35 AM, Anton Khirnov wrote: > > --- > > libavformat/movenc.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > > index b97c479cc4..30cfbf6e74 100644 > > --- a/libavformat/movenc.c > > +++ b/libavformat/movenc.c > > @@ -8230,11 +8230,11 @@ const FFOutputFormat ff_mov_muxer = { > > .write_packet = mov_write_packet, > > .write_trailer = mov_write_trailer, > > .deinit = mov_free, > > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS > > #if FF_API_ALLOW_FLUSH > > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, > > -#else > > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE, > > + | AVFMT_ALLOW_FLUSH > > #endif > > + , > > .p.codec_tag = (const AVCodecTag* const []){ > > ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0 > > }, > > @@ -8282,11 +8282,11 @@ const FFOutputFormat ff_mp4_muxer = { > > .write_packet = mov_write_packet, > > .write_trailer = mov_write_trailer, > > .deinit = mov_free, > > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS > > #if FF_API_ALLOW_FLUSH > > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, > > -#else > > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE, > > + | AVFMT_ALLOW_FLUSH > > #endif > > + , > > .p.codec_tag = mp4_codec_tags_list, > > .check_bitstream = mov_check_bitstream, > > .p.priv_class = &mov_isobmff_muxer_class, > > There's a custom check for these muxers in > avformat_transfer_internal_stream_timing_info() that would afaict be > disabled with this change. good? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".