Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR
Date: Tue, 02 Jul 2024 11:37:48 +0200
Message-ID: <171991306857.21847.17425905695975657583@lain.khirnov.net> (raw)
In-Reply-To: <edd27fb5-5eb4-413b-a65c-f8796eb53874@gmail.com>

Quoting James Almer (2024-03-30 13:49:07)
> On 3/29/2024 5:35 AM, Anton Khirnov wrote:
> > ---
> >   libavformat/movenc.c | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > index b97c479cc4..30cfbf6e74 100644
> > --- a/libavformat/movenc.c
> > +++ b/libavformat/movenc.c
> > @@ -8230,11 +8230,11 @@ const FFOutputFormat ff_mov_muxer = {
> >       .write_packet      = mov_write_packet,
> >       .write_trailer     = mov_write_trailer,
> >       .deinit            = mov_free,
> > +    .p.flags           = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS
> >   #if FF_API_ALLOW_FLUSH
> > -    .p.flags           = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE,
> > -#else
> > -    .p.flags           = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE,
> > +                       | AVFMT_ALLOW_FLUSH
> >   #endif
> > +                         ,
> >       .p.codec_tag       = (const AVCodecTag* const []){
> >           ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0
> >       },
> > @@ -8282,11 +8282,11 @@ const FFOutputFormat ff_mp4_muxer = {
> >       .write_packet      = mov_write_packet,
> >       .write_trailer     = mov_write_trailer,
> >       .deinit            = mov_free,
> > +    .p.flags           = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS
> >   #if FF_API_ALLOW_FLUSH
> > -    .p.flags           = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE,
> > -#else
> > -    .p.flags           = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE,
> > +                       | AVFMT_ALLOW_FLUSH
> >   #endif
> > +                         ,
> >       .p.codec_tag       = mp4_codec_tags_list,
> >       .check_bitstream   = mov_check_bitstream,
> >       .p.priv_class      = &mov_isobmff_muxer_class,
> 
> There's a custom check for these muxers in 
> avformat_transfer_internal_stream_timing_info() that would afaict be 
> disabled with this change.

good?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".