From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B8C3E48358 for ; Wed, 26 Jun 2024 16:23:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6691D68D428; Wed, 26 Jun 2024 19:23:16 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 851F468CBBF for ; Wed, 26 Jun 2024 19:23:09 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=V3l45pNV; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 0C368240DAC for ; Wed, 26 Jun 2024 18:23:08 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id M0WdZ989g1Kq for ; Wed, 26 Jun 2024 18:23:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719418987; bh=TKsfx/CNTPb9OSOYLNRyDQTw09oiolYhInJNW8y1hf8=; h=Subject:From:To:In-Reply-To:References:Date:From; b=V3l45pNVumR4plMusAkkJOmVJDrqjHbUphJiCbxWntkZzXr6WZI//8mah1eoXU1ce fsp8oX+XGwR2w51mwATMK3+n+66Jxlp59TJl+UCUpv9iMdtFd9jmYwosR9JshMWuD8 4BI9bGZ4l5VIqHWfMYzlygznLQGRFv+PvGgXRgAF6BkxMZXmwgaPevTn6EyjDvknQd crcoQqDgSe4yQ/sQ0TTYezdvgywdGeAyQzEqfubFWBdidkWufyD9xZ00bk3XQYFWRs iE9oCXqVOhsflkUElV6eZch7+y9AzRWcZY+HiKxC1oaQpZDuIbhYQMHxe/1rkgFZip qWGevpTX/PVZQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 546D92404E5 for ; Wed, 26 Jun 2024 18:23:07 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3C0EC1601B9; Wed, 26 Jun 2024 18:23:01 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240626124337.14478-1-anton@khirnov.net> <20240626124337.14478-2-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 26 Jun 2024 18:23:01 +0200 Message-ID: <171941898122.21847.16801978407261594878@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/5] lavc/hevcdec: do not call export_stream_params_from_sei() in update_thread_context() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-06-26 18:13:44) > Anton Khirnov: > > It is redundant, since it only sets AVCodecContext fields that are > > already copied by the generic code. > > --- > > libavcodec/hevc/hevcdec.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c > > index e80f2f28c7..4a62170073 100644 > > --- a/libavcodec/hevc/hevcdec.c > > +++ b/libavcodec/hevc/hevcdec.c > > @@ -3637,10 +3637,6 @@ static int hevc_update_thread_context(AVCodecContext *dst, > > s->sei.common.content_light = s0->sei.common.content_light; > > s->sei.common.aom_film_grain = s0->sei.common.aom_film_grain; > > > > - ret = export_stream_params_from_sei(s); > > - if (ret < 0) > > - return ret; > > - > > return 0; > > } > > #endif > > Won't this simply reopen ticket #8610 (when only patches 1+2 are applied)? I did test the sample from that issue and it exports the correct value with any thread count. TBH I don't quite understand why the call was added here in the first place, as it never should have been needed. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".