From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8500B4AFE8 for ; Wed, 26 Jun 2024 07:29:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 324C768D3F8; Wed, 26 Jun 2024 10:29:37 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9029468C75C for ; Wed, 26 Jun 2024 10:29:30 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=gv/rrgQT; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 42BD1240DAC; Wed, 26 Jun 2024 09:29:30 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id eHB2dj1bsdld; Wed, 26 Jun 2024 09:29:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719386969; bh=GCEd5Fz4NHneio8uzzjHQBTpUjV9ReIsbQ8wz01T23A=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=gv/rrgQTFrZVYTMi+ao5iyI3cdM3jGQUB4Uzo5FME6ToO2lO2CHr+80rF/4MAdXLQ 7OoKucRKsPp8F5ZUZCDE0v0YWhXbG8M2ho3UCi4N/mhxpDe1dk4sKyfebuuPIu73jR ug51Erbg6CPjxd32SszKJA4DOJl35RWUILRHqh1iIW7JvN3V8h7ifMim/cWTkTw99u L7hvleF2X7DB24VD81WZkXtdJ2ZGH0IA1ZofPBc/ROa9KkY3IhCouHHjv7I1YTtHZi XzoSvIEAbjmu9Jfs8X3PGM0jKRT3k9TpvgkZG9aYWHHcwr0R+RlxqxRSggIZRo6f3d kpQ0pvRKWQCVg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B52562404E5; Wed, 26 Jun 2024 09:29:29 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 950201601B9; Wed, 26 Jun 2024 09:29:29 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <560254a6-8238-4c51-9962-01150c54dc69@lynne.ee> References: <20240616085454.2560973-1-dev@lynne.ee> <20240616085454.2560973-6-dev@lynne.ee> <171860975126.28895.10121911707227811924@lain.khirnov.net> <036e660f-83b9-4c23-8df8-f91514a93b85@lynne.ee> <560254a6-8238-4c51-9962-01150c54dc69@lynne.ee> Mail-Followup-To: FFmpeg development discussions and patches , Lynne Date: Wed, 26 Jun 2024 09:29:29 +0200 Message-ID: <171938696958.21847.763645151567647666@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/6] aacdec_usac, aacsbr: implement SBR support for USAC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne via ffmpeg-devel (2024-06-17 21:04:30) > On 17/06/2024 21:01, Lynne wrote: > > On 17/06/2024 09:35, Anton Khirnov wrote: > >> No tests? > > > > Tests for this particular part are tricky. We still have the SBR issue > > where we add a single sample of delay to the output, which the reference > > samples and their decodings do not. Adding a test would mean modifying > > the samples in a way where we would not be able to use them after fixing > > this (in addition to all the other regular AAC samples with SBR we have > > that would become irrelevant). > > > > My plan is to fix this after this patch, as its a troublesome topic. > > Additionally, we also don't correctly take into account encoder SBR > delay signalled via MP4. Imperfect tests are better than no tests, just note their deficiencies in a comment next to the test target. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".