From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6029B49A07 for ; Wed, 26 Jun 2024 06:38:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C484768D4BF; Wed, 26 Jun 2024 09:38:50 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFF1D68D265 for ; Wed, 26 Jun 2024 09:38:43 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=gBsvdGzG; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B3198240DAC for ; Wed, 26 Jun 2024 08:38:43 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id eOUVIdHkcSSG for ; Wed, 26 Jun 2024 08:38:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719383923; bh=SOgGCxTHPc8QEdhzyo15UP1YM1TviS/1Rb7JEr9ENI0=; h=Subject:From:To:In-Reply-To:References:Date:From; b=gBsvdGzGD2G2n+jmyUE+77Ccu6R1+zP/3hm5M1DBzY8S2TUvFHu9MWzMRzRlu/Zse NaAVoOJPE/fG3fUrqi0X+PtW81RjXALuj4rXRyRbAmqxUem+WPXxah84NnIRArTT34 rleDLviK1/RciZYlzAd0gZAdDK5M4YvmhyBv1zmIVx6N1gd8WHdPnr/BfXvBERluYu uOmLqQThzkda2JoBLaKHRwCCPhjS2itcRPrv68JB5EqP5EE1yk6eyUiVkrFMJbFrJd Q81qMlfru70L78jfGpNs5eLZ85dOPtmEwLBuL7V7Bv2GN5VzK3T9BjxI9NXODeQoL9 s55iCPyciCA2g== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 33DCD2404E5 for ; Wed, 26 Jun 2024 08:38:43 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 144071601B9; Wed, 26 Jun 2024 08:38:43 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240625235230.GP4991@pb2> References: <20240623230137.1749178-1-michael@niedermayer.cc> <20240623230137.1749178-3-michael@niedermayer.cc> <171930604439.21847.16560242901412368252@lain.khirnov.net> <20240625235230.GP4991@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 26 Jun 2024 08:38:43 +0200 Message-ID: <171938392304.21847.16196117188798759434@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc/hevcdec: SPS not set (or cleared) after frame start X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-06-26 01:52:30) > On Tue, Jun 25, 2024 at 11:00:44AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-06-24 01:01:35) > > > Fixes: NULL pointer dereference > > > Fixes: 69623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6549698459009024 > > > > seems wrong > > Quite possible, but also your comment seems designed to be unhelpfull > you leave the reader guessing what issue you saw exactly and why and > what you think is better. My comment is designed to be as helpful as your commit message. "Fixes: NULL pointer dereference" says almost nothing about what actually goes wrong. It should be impossible to get to that point with the SPS being unset. Assuming it somehow does happen, the correct fix is to prevent it from happening, not add random checks to random places. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".