From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping
Date: Tue, 25 Jun 2024 15:54:21 +0200
Message-ID: <171932366170.21847.10333526120990190669@lain.khirnov.net> (raw)
In-Reply-To: <CAPYw7P4CY5U_=HH4u13XP9UANk-yBC8+wyuN5g-upxA=Gimf1Q@mail.gmail.com>
Quoting Paul B Mahol (2024-06-25 15:23:53)
> On Tue, Jun 25, 2024 at 3:12 PM Anton Khirnov <anton@khirnov.net> wrote:
> > I expect plenty of broken files from various sources where the user will
> > want to selectively ignore either codec or container cropping.
> > So we could make this an enum option, with values
> > none/all/codec/container, mapping to 0/1/2/3 respectively. That should
> > keep compatibility with current syntax.
> >
>
> Enum? Why not flags?
For compatibility reasons we want 1 to be 'all'.
The other option is to special-case numeric values.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-25 13:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 21:46 [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type James Almer
2024-05-29 21:46 ` [FFmpeg-devel] [PATCH 2/6] avformat/dump: print Frame Cropping side data info James Almer
2024-05-29 21:46 ` [FFmpeg-devel] [PATCH 3/6] avformat/matroskadec: export cropping values James Almer
2024-06-01 11:24 ` Kacper Michajlow
2024-07-05 20:51 ` James Almer
2024-05-29 21:46 ` [FFmpeg-devel] [PATCH 4/6] avformat/matroskaenc: support writing " James Almer
2024-05-29 21:46 ` [FFmpeg-devel] [PATCH 5/6] fftools/ffmpeg: support applying container level cropping James Almer
2024-05-30 1:01 ` Lynne via ffmpeg-devel
2024-05-30 1:04 ` James Almer
2024-05-31 1:13 ` Lynne via ffmpeg-devel
2024-05-30 22:57 ` Michael Niedermayer
2024-05-30 23:22 ` [FFmpeg-devel] [PATCH 1/2 v2] " James Almer
2024-06-25 10:25 ` Anton Khirnov
2024-06-25 12:38 ` James Almer
2024-06-25 13:12 ` Anton Khirnov
2024-06-25 13:23 ` Paul B Mahol
2024-06-25 13:54 ` Anton Khirnov [this message]
2024-06-25 10:19 ` [FFmpeg-devel] [PATCH 5/6] " Anton Khirnov
2024-07-02 16:49 ` [FFmpeg-devel] [PATCH 5/6 v3] " James Almer
2024-07-02 17:55 ` Anton Khirnov
2024-07-02 18:43 ` James Almer
2024-07-02 19:00 ` Anton Khirnov
2024-05-29 21:46 ` [FFmpeg-devel] [PATCH 6/6] fftools/ffplay: " James Almer
2024-05-30 1:02 ` [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type Lynne via ffmpeg-devel
2024-05-30 1:08 ` James Almer
2024-06-25 18:13 ` Andreas Rheinhardt
2024-06-25 18:17 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171932366170.21847.10333526120990190669@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git