From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 01CAF4AEB6 for ; Tue, 25 Jun 2024 09:10:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D359168CFAD; Tue, 25 Jun 2024 12:10:29 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4128868C620 for ; Tue, 25 Jun 2024 12:10:23 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=cE7Gvgdy; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id AD79C240DAC; Tue, 25 Jun 2024 11:10:22 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id gBzrRGLc7djZ; Tue, 25 Jun 2024 11:10:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719306622; bh=NgNp3686JKcUFCjcj9tAkq1E5Z0GTKL3TQTqD8bC37s=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=cE7GvgdyMIU6YsIA+VM1OIF2u+0+/yjYSMuJQ0XO+flYkEsYZRt/+LdKWf3oppbc+ ZybdhH721mIQDQDt2M0f+/a6tZPM4+ZGCW7DBWATBE+LBEpKBKSZ9iZvP6MzFZkVOQ vRpYVqbt6UnJx20UxoID6mU/pcwonrRH5NekptbH5IBaTC5gkfo3+ckNKq2nNnFx5Y i+YzEc47O+QTK0e5wN4fZNJh+e2XHpw+vwfY2/jzb40U/C9n6sNTuyqeSlhajWZISp gBm6FZfpwxhK3kHaKdVayNNs0MJMkKfn1nBQ7QiyTsmDcQ3e6oyaHFPrExvYnoB4RY 55Mqb1mpq+iFw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 39DEA2404E5; Tue, 25 Jun 2024 11:10:22 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 1935C1601B9; Tue, 25 Jun 2024 11:10:22 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Stefan Oltmanns Date: Tue, 25 Jun 2024 11:10:22 +0200 Message-ID: <171930662207.21847.17158610043019227483@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Stefan Oltmanns Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefan Oltmanns via ffmpeg-devel (2024-06-22 03:37:03) > Hello, > > this is my first patch, I hope I got all the formalities correct. > > The current VapourSynth implementation is rarely used, as it links the > VapourSynth library at build time, making the resulting build unable to > run when VapourSynth is not installed. Therefore barely anyone compiles > with VapourSynth activated. > > I changed it, so that it loads the library at runtime when a VapourSynth > script should be opened, just like AviSynth does. > On Windows the DLL from VapourSynth is not installed in the system > directory, but the location is stored in the Registry. Therefore I added > some code to read that information from the registry. > > As the V4 API is designed with dynamic loading in mind (only a single > import), I updated the implementation to V4 (changes are mostly > superficial, no structural changes). The V4 API is already several years > old, fully supported since R55 released in 2021. > > I copied the two needed header files directly in a vapoursynth.h, > removing the need to install VapourSynth on the build machine > (VapourSynth is also LGPL 2.1 or later, so no license issue). I updated > the configure so that it checks for the ability to load libraries at > runtime for VapourSynth, just like AviSynth and activate it if not disabled. > > make fate runs without any issue. I tested VapourSynth input scripts > with various color formats on different platforms: > > Ubuntu 22.04 > macOS 13 (x86_64) > macOS 13 (arm64) > Windows 10 (msys2/gcc) > > It compiles on these platforms without any warning and runs without any > issues. Sorry, this is entirely unacceptable. Especially the part instaling atexit handlers and bundling downstream headers, but overall we prefer to avoid dlopen. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".