From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68CC64AE9F for ; Tue, 25 Jun 2024 08:45:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D12B768D40C; Tue, 25 Jun 2024 11:45:56 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 598ED68B4F8 for ; Tue, 25 Jun 2024 11:45:50 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=bgO6OoS6; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B2F7F240DAC; Tue, 25 Jun 2024 10:45:49 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 9B8bOyt-0aUc; Tue, 25 Jun 2024 10:45:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719305149; bh=soPkMNLDV+tBi0iddSs5j2/L8lvSBBTbgl0xrxLYfDY=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=bgO6OoS60OfkQNAS6JapilkQRLgKDWw1ogCV3PpTrYQxCTWlog1ZLMNtTpUI0wqZE SFAahFslCJwcPVR9pp3outlRzdV2V80ljUUq/CKSSv76hnU6Q3ek3wea0vEPuVKM2Y dO4tFD2hiF+gofWQT0wbmWGTBfFTwtDnGfv5D38nP/Cf1h4Rkv84wHbZTfzOulyOIF GL9m/v864ZE+YcqKw548iSw8z/NBKpntfF9l1bHP1q5pLiJz2d9Fp8uQR8+yJhewdD lxSI1CJSHgQjIqsKClUh4/XYPbiyng8qYKD6NEFziY6jTdHVa/vV/FUy1q0oMu8Qmx 7dajRe/jOLwLQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0F2182404E5; Tue, 25 Jun 2024 10:45:49 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id EDDD01601B9; Tue, 25 Jun 2024 10:45:48 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240624185059.16797-1-chun.m.chang@gmail.com> References: <20240624185059.16797-1-chun.m.chang@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Chun-Min Chang Date: Tue, 25 Jun 2024 10:45:48 +0200 Message-ID: <171930514894.21847.6981635989494341833@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Allow enabling SVC in libaomenc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Chun-Min Chang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Chun-Min Chang (2024-06-24 20:50:59) > + const AVDictionaryEntry *en = NULL; > + while ((en = av_dict_iterate(ctx->svc_parameters, en))) { > + if (!strlen(en->value)) > + return AVERROR(EINVAL); > + > + if (!strcmp(en->key, "number_spatial_layers")) > + svc_params.number_spatial_layers = strtoul(en->value, NULL, 10); > + else if (!strcmp(en->key, "number_temporal_layers")) > + svc_params.number_temporal_layers = strtoul(en->value, NULL, 10); > + else if (!strcmp(en->key, "max_quantizers")) > + aom_svc_parse_int_array(svc_params.max_quantizers, en->value, AOM_MAX_LAYERS); > + else if (!strcmp(en->key, "min_quantizers")) > + aom_svc_parse_int_array(svc_params.min_quantizers, en->value, AOM_MAX_LAYERS); > + else if (!strcmp(en->key, "scaling_factor_num")) > + aom_svc_parse_int_array(svc_params.scaling_factor_num, en->value, AOM_MAX_SS_LAYERS); > + else if (!strcmp(en->key, "scaling_factor_den")) > + aom_svc_parse_int_array(svc_params.scaling_factor_den, en->value, AOM_MAX_SS_LAYERS); > + else if (!strcmp(en->key, "layer_target_bitrate")) > + aom_svc_parse_int_array(svc_params.layer_target_bitrate, en->value, AOM_MAX_LAYERS); > + else if (!strcmp(en->key, "framerate_factor")) > + aom_svc_parse_int_array(svc_params.framerate_factor, en->value, AOM_MAX_TS_LAYERS); So you declare a new dict-type option, then parse this dict manually instead of AVOptions doing this work for you? Why? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".