From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A7BA4AE85 for ; Tue, 25 Jun 2024 08:43:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9FFC068D3C1; Tue, 25 Jun 2024 11:43:01 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3EE668CDAA for ; Tue, 25 Jun 2024 11:42:55 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=RDmExy9W; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4EB72240DAC for ; Tue, 25 Jun 2024 10:42:55 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id GqnpTDEq1ySw for ; Tue, 25 Jun 2024 10:42:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1719304974; bh=8N9OhHZVGa7hQpyQa93BjFkZpo+M7X/3jWQcABueMmo=; h=Subject:From:To:In-Reply-To:References:Date:From; b=RDmExy9WjbLBAJANDRfbj7kIdQRwzziFQzuERR3ytjolGppcbMb08DjwA7BOVUwGL 7TeTWXLL3a4raLqrSlJ1VZDOXXc3scCuSsJrnQjdgN//OEU0PyqKgmeJn8wHf0au7n x+XL2B0nk5PzV9lD8Q5JjUA87+Xk7tPg4c0PhHn8Q8wrpeTdJQKAdy+pzSBBpTEHPr eiANTzMoctZJJjjDJSTWzq0Zzxf2yUdvZpQhlh3FaPwh0Lg68rgh83auOyJ6wVRZT5 /d/+kujw0JCVr94zL8tDiWRpyJjKVx2Yv00ivrR6ie5k/9vrX3DBcSDKWmWeIX+P6Y KE9zvur9tjvAA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B517B2404E5 for ; Tue, 25 Jun 2024 10:42:54 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 96C7E1601B9; Tue, 25 Jun 2024 10:42:54 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240622024111.6598-1-jamrial@gmail.com> References: <20240622012531.5523-1-jamrial@gmail.com> <20240622024111.6598-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 25 Jun 2024 10:42:54 +0200 Message-ID: <171930497458.21847.144489672431390027@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: add a Stereo3D type to signal that the packing is defined by the view field X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-06-22 04:41:11) > Given that a video stream/frame may have only one view coded, or both packed in > an undefined way, and as the values of AVStereo3DView and AVStereo3DType may > clash (namely if type is AV_STEREO3D_2D, then AV_STEREO3D_VIEW_PACKED would be > invalid, and if it's anything other than it, then only AV_STEREO3D_VIEW_PACKED > would be valid), this commit adds a new type value AV_STEREO3D_VIEW that > signals the user that AVStereo3D.view contains information about the nature of > the stream, with the added constrain that AVStereo3D.view should be ignored if > AVStereo3D.type is anything other than AV_STEREO3D_VIEW. > > Signed-off-by: James Almer > --- > This is the only way i could think of to work around the fact AVStereo3DType > and AVStereo3DView just can't work well together if we want to keep AVStereo > backwards compatible. I don't really see what actual problem is this supposed to address, rather it seems to me it just muddles the situation further. When type is AV_STEREO3D_2D, the video is monoscopic and everything else in AVStereo3D should be ignored. In this light I also don't see the point of patch 1. Nontrivial values of AVStereo3DView are meaningful only for a stereoscopic non-packed video, i.e. AV_STEREO3D_FRAMESEQUENCE. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".