From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2DE3D4A12F for ; Fri, 21 Jun 2024 11:53:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5C52A68D7A8; Fri, 21 Jun 2024 14:52:59 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A824468D6B4 for ; Fri, 21 Jun 2024 14:52:52 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Ghi3nmIT; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 623D9240DAC; Fri, 21 Jun 2024 13:52:52 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id uykQBBwrkJHU; Fri, 21 Jun 2024 13:52:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1718970771; bh=Pf8NTcAHE9HI49WSXJjRBhti5E1poC81RUkQUO/HBis=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=Ghi3nmITAFckVn40usAA6E7AXRIUyNjFqex1ucyNb86/YtahN0/1Q4+mWfsfi/iOB AcEILZNrO0jAbbr02Tl/SzT5WlPxvwo47RfxksNoyYn2WJbfmuDRWTZiWGBWR1xKi2 z79y/d7V5fKN1VxgB3osmNVNP4Q4sNEZpAbL5Ru+ijksIIKBCeklajQtNz7qpXS9i3 DM2kM4RaKBk777nvcVNe0Wv+Tx3EsT0U0KA7jJ0tQQSuGRbPF/w8e7b1+BptBVRIRZ RI+ahtZ8jqgyeV60d4TVbe8KxpZhYAMZKTUsze4CIgnAqC44J8F+t1Kg+y0T1zifpi PqBKLWWl3LC2A== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B8FF82404E5; Fri, 21 Jun 2024 13:52:51 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 616151601B9; Fri, 21 Jun 2024 13:52:51 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240621104323.92453-3-thilo.borgmann@mail.de> References: <20240621104323.92453-1-thilo.borgmann@mail.de> <20240621104323.92453-3-thilo.borgmann@mail.de> Mail-Followup-To: FFmpeg development discussions and patches , Thilo Borgmann Date: Fri, 21 Jun 2024 13:52:51 +0200 Message-ID: <171897077136.28895.4532993299698237033@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v13 2/8] avcodec/webp: separate VP8 decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Thilo Borgmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Thilo Borgmann via ffmpeg-devel (2024-06-21 12:43:17) > From: Thilo Borgmann via ffmpeg-devel > > --- > libavcodec/webp.c | 50 +++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 44 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/webp.c b/libavcodec/webp.c > index af4ebcec27..c52b9732b4 100644 > --- a/libavcodec/webp.c > +++ b/libavcodec/webp.c > @@ -195,6 +195,7 @@ typedef struct WebPContext { > AVFrame *alpha_frame; /* AVFrame for alpha data decompressed from VP8L */ > AVPacket *pkt; /* AVPacket to be passed to the underlying VP8 decoder */ > AVCodecContext *avctx; /* parent AVCodecContext */ > + AVCodecContext *avctx_vp8; /* wrapper context for VP8 decoder */ As I said before, nested decoders should be avoided whenever possible, because properly forwarding everything between the caller and the nested decoder is very tricky and almost never fully correct. For example, this patch seems to break direct rendering. And even if a nested decoder is unavoidable for some reason, it need a lot more justification than none. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".