From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 695F449475 for ; Tue, 11 Jun 2024 11:23:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DA9968D827; Tue, 11 Jun 2024 14:23:11 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 18A4968D7C7 for ; Tue, 11 Jun 2024 14:23:04 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=EdBBURqa; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C40E5240DAC; Tue, 11 Jun 2024 13:23:03 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 41bYIR9HerRZ; Tue, 11 Jun 2024 13:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1718104983; bh=4a/9v+T4fWC+78H8Y6/BA1Q9NCwOGCkUkfCcE5RXyBs=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=EdBBURqasT3w+4NIntdg/kZc6/YwnsGF502dp1IbJMVmfwI5p9BVv9i+exVbRbDQH yXxehViRTdk1BC0E60hLdNwTeXVgDH2rYeuilQtKPmpuBuHBgOPy142QTUZR8WEtMd adwwaKPS9V51qATSWbh4v2UVnLDTyyz6DfuiupEleQKQ8KRtodyRfzxjF/46U+bGjs u0bUwQMFLMvzQVwQpcwbV+YILZiNkGG237QKsIP9t+sQFexLcFtpkr1jwf3I1sCLpn uUDVZ5R01ZC705zZFtjlMLHumEvXy5TZN+aeud+poTU+0it5UEOKleDDcom7a+ojYw fmHCVgtIafHCw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 051132404E5; Tue, 11 Jun 2024 13:23:03 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id DAE651601B9; Tue, 11 Jun 2024 13:23:02 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Tue, 11 Jun 2024 13:23:02 +0200 Message-ID: <171810498286.28895.10846970243807378471@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_mux_init: Fix leak when using non-encoding option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-06-11 08:37:59) > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_mux_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c > index 2ed4171a75..e25c6e7e24 100644 > --- a/fftools/ffmpeg_mux_init.c > +++ b/fftools/ffmpeg_mux_init.c > @@ -3146,6 +3146,7 @@ static int validate_enc_avopt(Muxer *mux, const AVDictionary *codec_avopt) > if (!(option->flags & AV_OPT_FLAG_ENCODING_PARAM)) { > av_log(mux, AV_LOG_ERROR, "Codec AVOption %s (%s) is not an " > "encoding option.\n", e->key, option->help ? option->help : ""); > + av_dict_free(&unused_opts); > return AVERROR(EINVAL); LGTM -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".