From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 64D214B3E3 for ; Wed, 5 Jun 2024 08:41:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F0E5D68D73D; Wed, 5 Jun 2024 11:41:07 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9613268D40C for ; Wed, 5 Jun 2024 11:41:01 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=d+q0z5R9; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4C862240DAC; Wed, 5 Jun 2024 10:41:01 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id vqxV7TQ_7pbJ; Wed, 5 Jun 2024 10:41:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1717576860; bh=GxETvwLwxkYjynq6oKIlaVO2b0oUDO0T0h/OJMhqffU=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=d+q0z5R9cl2CHAqYZMfWnEIdZXb8k8olkYME+o4k44MVpWqrgYPvGWz/zAIO5Ze0g UaWoZJEk/4FsAnU23omag2d0kalC3Ps/+za+/cF58QI4jle4bW3I0uEVf1DiBT/yo2 wzF6/SOhfj1nbifq3TYSfo2syE+ono5CgCHFdOQiCCEuT0VKKU01NIUiTlUkRCODqy dArDYcQzvkQtl7hLvGe3W1LEef25PMgkRXKxNoMn9QvleI3wxXT0n81MJ6foJudnZB kmGL/MJoM16KsNCPT4/6t9uj+aUN5bor/ab+1M5xjVSkRt72u+eXE3OIW8qWlgNR+G aUbI+MfXct+4Q== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5C8FA2404E5; Wed, 5 Jun 2024 10:41:00 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 392AF1601B9; Wed, 5 Jun 2024 10:41:00 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240603214847.19205-1-cus@passwd.hu> References: <20240603214847.19205-1-cus@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint Date: Wed, 05 Jun 2024 10:41:00 +0200 Message-ID: <171757686020.28895.16834592342050862228@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: gracefully ignore mismatching channel layouts for -channel_layout option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-06-03 23:48:47) > The very old behaviour of -channel_layout was to simply warn the user about > channel layouts which does not have a matching channel count, and ignore them, > instead of reporting an error. > > The recent fix re-added support for overriding -channel_layout, but it rejected > mismatching layouts. There is no easy way for the user to specify a channel > layout only for streams with matching number of channels, so this patch > restores the very old behaviour of ignoring mismatching layouts. See the > discussion in ticket #11016. I'm ambivalent about this. On one hand it probably doesn't hurt, for now at least, on the other it seems quite ad-hoc. Previously it worked this way mostly by accident, whereas if we now restore this behaviour deliberately we'll be committing to supporting it for the foreseeable future. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".