From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 42FC648ADA for ; Fri, 31 May 2024 07:39:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D762968D4BA; Fri, 31 May 2024 10:39:15 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EE70368CCB1 for ; Fri, 31 May 2024 10:39:08 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=kajSu2tX; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A9078240DAC for ; Fri, 31 May 2024 09:39:08 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id IwATVHpGFMiX for ; Fri, 31 May 2024 09:39:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1717141147; bh=8UTv49AXedncRqTDKIb1GBpkRb6m/mFSvfR0oMinhoQ=; h=Subject:From:To:In-Reply-To:References:Date:From; b=kajSu2tXqy0Z/6jgGlWu6XRxTG5jTupt4nwBxxBrn4krcyC/kB9HJ51ZrMQoIAgsj O7Zm89+BAowlkM2iViCVcWBoMBLiVFj1v3wNCN6zVNbtnCc/bcZpYCWkXYngnauYAK HtNoZecGYr5cnmQ6V86vygL0R0r6LB/9MT8kih7x9RbP7FMXAWzPIW7uwwpmRmNZZD h1Sf7DpbzKPx2zJSi/aDDPP9vt9ABSLZ35IoWgfIM0275itK93duBjyH0JuRm7bdKG gQQZJg8AOik2rMicxlQFjJGXBcel2LafKtnx8Mdhc8x6gTnzs/CS7Uz+MCKCTokI49 PNznfWadvLxNw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E90592404E5 for ; Fri, 31 May 2024 09:39:07 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id C830D1601B9; Fri, 31 May 2024 09:39:07 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240427003623.118199-1-michael@niedermayer.cc> <171679774316.28895.4366606367617414113@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 31 May 2024 09:39:07 +0200 Message-ID: <171714114779.28895.8992353908239121460@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-05-27 16:11:13) > On 5/27/2024 5:15 AM, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-04-27 02:36:23) > >> This allows detecting issues in side data related code, same as what > >> framecrc does for before already for packet data itself. > >> > >> Signed-off-by: Michael Niedermayer > >> --- > > > > I am against this patch. Checksumming side data is a fundamentally wrong > > thing to do. > > framehash should be updated to also not print hashes, then. Problem is > that it's versioned, so we would need to "deprecate" the current versions. > > There's also the issue of printing sizes, which for some structs (iamf, > video_enc_params) it can vary depending on target, so my suggestion was > adding an option to disable printing certain values like it. What do you > think? I agree. It's another aspect of the same issue - binary representation of side data is not guaranteed to be the same everywhere. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".