Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data

[Anton Khirnov <anton@khirnov.net>]

Quoting James Almer (2024-05-27 16:11:13)
> On 5/27/2024 5:15 AM, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2024-04-27 02:36:23)
> >> This allows detecting issues in side data related code, same as what
> >> framecrc does for before already for packet data itself.
> >>
> >> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> >> ---
> > 
> > I am against this patch. Checksumming side data is a fundamentally wrong
> > thing to do.
> 
> framehash should be updated to also not print hashes, then. Problem is 
> that it's versioned, so we would need to "deprecate" the current versions.
> 
> There's also the issue of printing sizes, which for some structs (iamf, 
> video_enc_params) it can vary depending on target, so my suggestion was 
> adding an option to disable printing certain values like it. What do you 
> think?

I agree. It's another aspect of the same issue - binary representation
of side data is not guaranteed to be the same everywhere.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".