From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C211C4B06D for ; Mon, 27 May 2024 09:08:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 01A6968D52C; Mon, 27 May 2024 12:08:00 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 86EAB68D119 for ; Mon, 27 May 2024 12:07:53 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=KJ7b3u0C; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 35785240DAC; Mon, 27 May 2024 11:07:53 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id iyUjGZnR3Nua; Mon, 27 May 2024 11:07:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716800872; bh=uF2PB4svzreOzfqqPGkTTFMMQ9sdeqvnsdL0ZB1Wxw8=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=KJ7b3u0CLZpafW155V53Aw/N9/4ZHwS3JTii2KAAjqjtBzDaGktl9SM4lzvj18WLL fp+F6GXLX8FlCCvC9sb6Dz5h2m6fUYq0c3im3etYT9GaYYCDrG59aMOW6BrRWLMh40 vpp9PlM3Wt3NkCha4k6DxDC/8wbINMONn9iZJDa2D31Q2o92SQWZO0NQ/TkURMW6Z/ SaO8Xhc89pn6UcG8oyNhEoZwt+JkeUB5/yfhw7O/+3DHkiB8gUcNyaXJfKsVEf63zf 0dzG/MeJYHpFN4cNIbImHiXUuqvmz4l2lGuM65cmQOGSVc2oBHKUOAUzsTOrZplFgZ IFVnMIpDsP8mA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 784932404E5; Mon, 27 May 2024 11:07:52 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 4FBB91601B9; Mon, 27 May 2024 11:07:52 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <15a18bff-046f-48fc-9e77-a5643ee07245@lynne.ee> References: <20240525022813.2292001-1-dev@lynne.ee> <20240525022813.2292001-2-dev@lynne.ee> <467d6a51-fe08-f8df-7d03-7d842ea804d3@passwd.hu> <18e1fbb8-3630-4c22-abbd-05f236107bc1@lynne.ee> <171679922894.28895.1703458970208394633@lain.khirnov.net> <15a18bff-046f-48fc-9e77-a5643ee07245@lynne.ee> Mail-Followup-To: FFmpeg development discussions and patches , Lynne Date: Mon, 27 May 2024 11:07:52 +0200 Message-ID: <171680087229.28895.12238547169461784801@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne via ffmpeg-devel (2024-05-27 10:54:40) > On 27/05/2024 10:40, Anton Khirnov wrote: > > Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41) > >> ...its an enum entry. Do you want a design document and a proposal? > >> You could talk to the person who did the research about it, JEEB. > >> Why wait at all? There's only you and JEEB that care about channel > >> layouts, you can review it and give it an LGTM. There's no reason to > >> wait for days, that is not how reviewing is supposed to work. > > > > That's exactly how reviewing is supposed to work. Waiting a few days > > won't kill anyone and allows more people to comment. > > > > To the contrary I'm quite unhappy with some recent instances of > > developers pushing code immediately upon seeing an LGTM, without giving > > other people the opportunity to look at it. > > I'd understand if it was for generic common code, but if its for code > that the one pushing it maintains, I don't see a problem with this, this > is how it works in pretty much every project out there. I do see a problem - just because you maintain the code doesn't mean you always understand all its aspects better than everyone, not to mention when reading your own code you tend to see what you meant to write rather than what you actually wrote. There's always a nontrivial possibility that someone could have a meaningful review comment, so why not wait a day or two? There's no harm in it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".