From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC
Date: Mon, 27 May 2024 10:40:28 +0200
Message-ID: <171679922894.28895.1703458970208394633@lain.khirnov.net> (raw)
In-Reply-To: <18e1fbb8-3630-4c22-abbd-05f236107bc1@lynne.ee>
Quoting Lynne via ffmpeg-devel (2024-05-26 23:42:41)
> ...its an enum entry. Do you want a design document and a proposal?
> You could talk to the person who did the research about it, JEEB.
> Why wait at all? There's only you and JEEB that care about channel
> layouts, you can review it and give it an LGTM. There's no reason to
> wait for days, that is not how reviewing is supposed to work.
That's exactly how reviewing is supposed to work. Waiting a few days
won't kill anyone and allows more people to comment.
To the contrary I'm quite unhappy with some recent instances of
developers pushing code immediately upon seeing an LGTM, without giving
other people the opportunity to look at it.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-27 8:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 2:27 [FFmpeg-devel] [PATCH v3 00/10] aacdec: add a native xHE-AAC decoder Lynne via ffmpeg-devel
2024-05-25 2:27 ` [FFmpeg-devel] [PATCH v3 01/10] channel_layout: add new channel positions supported by xHE-AAC Lynne via ffmpeg-devel
2024-05-25 6:10 ` Marton Balint
2024-05-26 18:16 ` Lynne via ffmpeg-devel
2024-05-26 20:51 ` Marton Balint
2024-05-26 21:35 ` [FFmpeg-devel] [PATCH v4] fate: add tests for xHE-AAC Lynne via ffmpeg-devel
2024-05-26 21:37 ` [FFmpeg-devel] [PATCH v4 01/10] channel_layout: add new channel positions supported by xHE-AAC Lynne via ffmpeg-devel
2024-05-27 14:11 ` Jan Ekström
2024-05-27 19:31 ` Marton Balint
2024-05-28 21:20 ` Jan Ekström
2024-05-28 21:38 ` Marton Balint
2024-05-28 22:12 ` Lynne via ffmpeg-devel
2024-05-29 19:41 ` Marton Balint
2024-05-26 21:42 ` [FFmpeg-devel] [PATCH v3 " Lynne via ffmpeg-devel
2024-05-27 8:40 ` Anton Khirnov [this message]
2024-05-27 8:54 ` Lynne via ffmpeg-devel
2024-05-27 9:07 ` Anton Khirnov
2024-05-27 10:48 ` Lynne via ffmpeg-devel
2024-05-25 2:27 ` [FFmpeg-devel] [PATCH v3 02/10] aacdec: move from scalefactor ranged arrays to flat arrays Lynne via ffmpeg-devel
2024-05-25 2:27 ` [FFmpeg-devel] [PATCH v3 03/10] aacdec: expose channel layout related functions Lynne via ffmpeg-devel
2024-05-25 2:27 ` [FFmpeg-devel] [PATCH v3 04/10] aacdec: expose decode_tns Lynne via ffmpeg-devel
2024-05-25 2:27 ` [FFmpeg-devel] [PATCH v3 05/10] aacdec_dsp: implement 768-point transform and windowing Lynne via ffmpeg-devel
2024-05-25 2:27 ` [FFmpeg-devel] [PATCH v3 06/10] aactab: add deemphasis tables for USAC Lynne via ffmpeg-devel
2024-05-25 2:28 ` [FFmpeg-devel] [PATCH v3 07/10] aactab: add tables for the new USAC arithmetic coder Lynne via ffmpeg-devel
2024-05-25 2:28 ` [FFmpeg-devel] [PATCH v3 08/10] aactab: add new scalefactor offset tables for 96/768pt windows Lynne via ffmpeg-devel
2024-05-25 2:28 ` [FFmpeg-devel] [PATCH v3 09/10] aacdec: add a decoder for AAC USAC (xHE-AAC) Lynne via ffmpeg-devel
2024-05-27 17:36 ` Andreas Rheinhardt
2024-05-25 2:31 ` [FFmpeg-devel] [PATCH v3 10/10] fate: add tests for xHE-AAC Lynne via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171679922894.28895.1703458970208394633@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git