From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 78ED04B06C for ; Mon, 27 May 2024 08:15:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C94C968D4EF; Mon, 27 May 2024 11:15:50 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 628A968D2A4 for ; Mon, 27 May 2024 11:15:44 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=bj1ysn87; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 1BE78240DAC for ; Mon, 27 May 2024 10:15:44 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id ZOZ3uLORQO5h for ; Mon, 27 May 2024 10:15:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716797743; bh=5sX/F6e1OG/WxzjnC+qzd9Lmm5kUzJBgBq3QIIJH89c=; h=Subject:From:To:In-Reply-To:References:Date:From; b=bj1ysn87Pv+6KX1v5rhhI1OFOjrVpfgwEgIbr5FHhLGxzeflqUHRc5AL2TeCgJnYz 4wKJr8RiTvYzcf4z8YWFOjuonnuzmJ1io3zfBpTXuiHp+9/1ykxKIdZqBmRRPnPW9z gHMjCP9yipHvYVb9AXu0++LQKsNTJNkZUjowI2A5iiKPfDRehI9gU4WbxI+LL5KpkT JZfB7YpPVZuRlE56Nr/9Dh50rqAG6RSOFuXdy9O/WdsVhh/W8HYKBGtToLXsSZwB8Z paMboTZN19hgWLeO4wbiLPAmRnZPpNs0ATs0vIs2qTeObMrYGMWwKhVdEPSdpe7rLW vKwwitp9q+N5A== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 528412404E5 for ; Mon, 27 May 2024 10:15:43 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2D7011601B9; Mon, 27 May 2024 10:15:43 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240427003623.118199-1-michael@niedermayer.cc> References: <20240427003623.118199-1-michael@niedermayer.cc> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 27 May 2024 10:15:43 +0200 Message-ID: <171679774316.28895.4366606367617414113@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/framecrcenc: compute the checksum for side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-04-27 02:36:23) > This allows detecting issues in side data related code, same as what > framecrc does for before already for packet data itself. > > Signed-off-by: Michael Niedermayer > --- I am against this patch. Checksumming side data is a fundamentally wrong thing to do. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".