From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D23C94B06D for ; Mon, 27 May 2024 08:01:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9CB4F68D4ED; Mon, 27 May 2024 11:01:35 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8622A68D4BE for ; Mon, 27 May 2024 11:01:28 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=ksAOJ+uA; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 46775240DAC; Mon, 27 May 2024 10:01:28 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id uB76p_yQYUc8; Mon, 27 May 2024 10:01:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716796887; bh=ajaDqjuYyaVriCDVwxDNN6Gn8oA2nIqwJSMmereAUk8=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=ksAOJ+uAmej0deaV8d1buzTqqYokHWg3oGxRn/QuZSLAK0EYYy/Kl41C09V0ysZs7 hLH7KZHc4OEmd5NXiRH62stamFsG6vEvy708968SQ8/2v97uGebvJYY0ZjRV+v0RPf E0lEQvFsFS4gKH3VXtqixP9ZVSIyxSd45R52rpgoqBeRQ8ZAK4izxox1KaW9qTsxq8 1wilhWjFTlHYLnaXIHGp/C4M7eyTGBY/zewPvmwXp0NYuxkC+yGWUu1UijIEcTzDQy H3UPLDdZPF6HLU+Fk4gO6HtrHrufILyh76eQxLAX+f7z+1GGbEWzs+Vh05TJoJd74b WpnmfIMi2kBHA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D6CCA2404E5; Mon, 27 May 2024 10:01:27 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id B62181601B9; Mon, 27 May 2024 10:01:27 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240519195258.13627-1-cus@passwd.hu> References: <20240518212048.GF2821752@pb2> <20240519195258.13627-1-cus@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint Date: Mon, 27 May 2024 10:01:27 +0200 Message-ID: <171679688772.28895.10431804740209107235@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-05-19 21:52:57) > The code only set the channel layout of the AVFormatContext, so the user could > not override the channel layout if the demuxer did not have such parameter. > > This used to work via the respective AVCodecContext option, but since > 639c2f00497257cb60ecaeeac1aacfa80df3be06 it no longer gets passed to the > decoders. It is actually better if we set it manually, instead of using the > codec option because that way we can also override it on the stream level, so > it will also work for stream copy or bitstream filtering. > > We don't allow changing the number of channels, because that can cause > unexpected results. We disable layout guessing, if a channel layout is > specified. > > Fixes ticket #11016. > > Signed-off-by: Marton Balint > --- > fftools/ffmpeg_demux.c | 27 ++++++++++++++++++++++++--- > 1 file changed, 24 insertions(+), 3 deletions(-) Looks ok -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".