From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8548B4B068 for ; Mon, 27 May 2024 07:58:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1653068D4EF; Mon, 27 May 2024 10:58:02 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D205B68D3C2 for ; Mon, 27 May 2024 10:57:55 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=iyZxKIbS; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 92E53240DAC; Mon, 27 May 2024 09:57:55 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id OMXzQvHzAsUQ; Mon, 27 May 2024 09:57:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716796674; bh=FaJuiuw9BC22wBvJ0bpKgbhPNU+Jdj+XPjdTeaQQEDw=; h=Subject:From:To:In-Reply-To:References:Date:From; b=iyZxKIbSyAs6TXHFLAGrTGFBziY8lAFo8ZtiI1MmylrjdEyrEZmB9F1vD0ibidzr5 GY9sS9z0JkBfZdzaU6x9asn+PRFcJPgdBLeJo/TI5NdVIXWVOThPdBUHExM9Ri52Gh xuqgApKLYPzIEsyQd131H1bG3jW6P+KaNFK6avvwMkNbaNfHaksHMPECzUVgGLtxCH nSjQFjHNHNateEkt2qfuSEfoGSMB2/WYttIa3PE9wnLBNlDJKozgDJk2VOb1YULDul 4JSaUmNi9700lv7TRw3qS1Af1gQD3avuKlYCA34mC6OxLXMFA7OFM0N3R8r7k1JOEC ehDSshinD+OTA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D0F3D2404E5; Mon, 27 May 2024 09:57:54 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id BE8EB1601B9; Mon, 27 May 2024 09:57:54 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches , Marton Balint In-Reply-To: <171679630996.28895.471585656981378600@lain.khirnov.net> References: <20240518161116.8661-1-cus@passwd.hu> <171679630996.28895.471585656981378600@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint Date: Mon, 27 May 2024 09:57:54 +0200 Message-ID: <171679667475.28895.8717065604036545989@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Anton Khirnov (2024-05-27 09:51:49) > I don't like modifying OptionsContext in its consumers (it's const for a > reason), and it's probably not even necessary - if the semantics of the > option is "override demuxer-reported channel layout", then you can just > override the demuxer-reported channel layout (similarly to how > guess_input_channel_layout() does it) and it will be communicated to the > decoder automagically. I see that's pretty much what you did in v2, so disregard the above email. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".