From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>, Marton Balint <cus@passwd.hu>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param
Date: Mon, 27 May 2024 09:57:54 +0200
Message-ID: <171679667475.28895.8717065604036545989@lain.khirnov.net> (raw)
In-Reply-To: <171679630996.28895.471585656981378600@lain.khirnov.net>
Quoting Anton Khirnov (2024-05-27 09:51:49)
> I don't like modifying OptionsContext in its consumers (it's const for a
> reason), and it's probably not even necessary - if the semantics of the
> option is "override demuxer-reported channel layout", then you can just
> override the demuxer-reported channel layout (similarly to how
> guess_input_channel_layout() does it) and it will be communicated to the
> decoder automagically.
I see that's pretty much what you did in v2, so disregard the above
email.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-27 7:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 16:11 Marton Balint
2024-05-18 16:11 ` [FFmpeg-devel] [PATCH 2/5] doc/ffmpeg: document -channel_layout/ch_layout options Marton Balint
2024-05-18 16:11 ` [FFmpeg-devel] [PATCH 3/5] fftools: move check_avoptions and remove_avoptions to cmdutils Marton Balint
2024-05-18 16:11 ` [FFmpeg-devel] [PATCH 4/5] fftools/ffplay: use cmdutils code for checking remaining avoptions Marton Balint
2024-05-18 16:11 ` [FFmpeg-devel] [PATCH 5/5] fftools/ffplay: allow unused format options which are also codec options Marton Balint
2024-05-18 21:20 ` [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param Michael Niedermayer
2024-05-19 19:52 ` [FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout Marton Balint
2024-05-19 19:52 ` [FFmpeg-devel] [PATCH v2 2/5] doc/ffmpeg: document -channel_layout/ch_layout options Marton Balint
2024-05-25 16:57 ` [FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout Marton Balint
2024-05-25 19:20 ` Anton Khirnov
2024-05-27 8:01 ` Anton Khirnov
2024-05-27 7:51 ` [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param Anton Khirnov
2024-05-27 7:57 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171679667475.28895.8717065604036545989@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git