From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31BA54AFE2 for ; Sat, 25 May 2024 19:20:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 124CA68D4D5; Sat, 25 May 2024 22:20:28 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90AB468D1BC for ; Sat, 25 May 2024 22:20:21 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Uwh+Pl9C; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EDC8F240DAC for ; Sat, 25 May 2024 21:20:20 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id m6f629tMBzq8 for ; Sat, 25 May 2024 21:20:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716664820; bh=UXJj7lpdBWlBdxvYaAqK9VgIc5HmjdVX6wXIt68q01U=; h=Subject:From:To:In-Reply-To:References:Date:From; b=Uwh+Pl9CN+F1d0/Uk2OgE6immic0BmnpAmpZf1O6lWTSenp2DokPpq4H7dbb0WAt9 3uTXyu4uKkMnHVvXFphTAA9sBzNSQkERFrCQPjIEpRKE6FzOdJ18bZwtaaz8MachjL XCy42iBc7i4PNNafRI7TKerCcKV5mdApHO9Ywuv1VtFD8qs2hACsZvMqKP2FdAt58i UlPGSfnQCNq1mMckOZEMogcumBXJBi1ZMldYjW0vQPkzoyuMRL1x2DJpTrNIebBnCn ejEjM4lx7cnTdO6rfGRvRi3p60JMXaz+p+1Q3TlybOlJhE0iCAshJFUen78t7lYBmb a2IjUfzQijHAw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 338412404E5 for ; Sat, 25 May 2024 21:20:20 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 1AEF81601B9; Sat, 25 May 2024 21:20:14 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <3ac2f52f-397b-e77b-dd99-0d3205cad12a@passwd.hu> References: <20240518212048.GF2821752@pb2> <20240519195258.13627-1-cus@passwd.hu> <3ac2f52f-397b-e77b-dd99-0d3205cad12a@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 25 May 2024 21:20:14 +0200 Message-ID: <171666481407.28895.5920557051979475076@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] fftools/ffmpeg_demux: honor -ch_layout options for overriding input stream channel layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-05-25 18:57:32) > > > On Sun, 19 May 2024, Marton Balint wrote: > > > The code only set the channel layout of the AVFormatContext, so the user could > > not override the channel layout if the demuxer did not have such parameter. > > > > This used to work via the respective AVCodecContext option, but since > > 639c2f00497257cb60ecaeeac1aacfa80df3be06 it no longer gets passed to the > > decoders. It is actually better if we set it manually, instead of using the > > codec option because that way we can also override it on the stream level, so > > it will also work for stream copy or bitstream filtering. > > > > We don't allow changing the number of channels, because that can cause > > unexpected results. We disable layout guessing, if a channel layout is > > specified. > > > > Fixes ticket #11016. > > Will apply the series. Could you please wait a few days? I'm just freshly back from a vacation and didn't have time to look at this in detail yet. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".