From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D78884AF24 for ; Fri, 24 May 2024 09:08:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3375568D544; Fri, 24 May 2024 12:07:58 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6628F68D355 for ; Fri, 24 May 2024 12:07:52 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=q0WPgXfR; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2E7C8240DAC for ; Fri, 24 May 2024 11:07:52 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id h2RK6iZF-2yV for ; Fri, 24 May 2024 11:07:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716541671; bh=ntSbmaSuHitYnQP/BBbckJPbGHlk2bjE0BH2dATT9O8=; h=Subject:From:To:In-Reply-To:References:Date:From; b=q0WPgXfRKJhg0s9ucH2wiq9HjY2vX5LK1YbuabuZMKPELrw6cUqzF2HNak7ok4J93 XJLSCafWfmnw6L88QWqUShuSIwClRD80HbmukkyXFtcEcYvD4Bezg+YUJ7O3S/TJvl glMt5SkNkM0mXBt/7GhPwHdSnWr9aNby0eDMD2R/8DCNVby2CpX5/iXIqkGtL92DOr ryRslm9UREKWvGYsHaqex8XfBXhRLCMZ7LeMULCfNyd/JxCNMLSMP7dPIwBrU+8Tm3 /u3SqUAJ7Pw8BzrINzDVjNtRIMxT/Wi0g+z081qSAQ0vTMLcT8kYKA1eKsr3mWH454 JtnD5X/ykt4Jw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 962522404E5 for ; Fri, 24 May 2024 11:07:51 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 838A01601B9; Fri, 24 May 2024 11:07:51 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240410133118.28144-1-anton@khirnov.net> <20240410133118.28144-6-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 24 May 2024 11:07:51 +0200 Message-ID: <171654167151.28895.5538833699602729953@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 06/10] lavc/hevc_ps/HEVCSPS: change flags into size-1 bitfields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-04-11 13:55:05) > Anton Khirnov: > > Reduces sizeof(HEVCSPS) by 96 bytes. > > > > Also improve flag names: drop redundant suffixes and prefixes, and > > consistently use disabled/enabled. > > --- > > libavcodec/dxva2_hevc.c | 24 ++++----- > > libavcodec/hevc_cabac.c | 36 ++++++------- > > libavcodec/hevc_filter.c | 8 +-- > > libavcodec/hevc_parser.c | 2 +- > > libavcodec/hevc_ps.c | 95 +++++++++++++++++----------------- > > libavcodec/hevc_ps.h | 62 +++++++++++----------- > > libavcodec/hevcdec.c | 10 ++-- > > libavcodec/hevcpred_template.c | 4 +- > > libavcodec/mips/hevcpred_msa.c | 6 +-- > > libavcodec/nvdec_hevc.c | 42 +++++++-------- > > libavcodec/qsvenc_hevc.c | 2 +- > > libavcodec/vaapi_hevc.c | 42 +++++++-------- > > libavcodec/vdpau_hevc.c | 36 ++++++------- > > libavcodec/vulkan_hevc.c | 56 ++++++++++---------- > > 14 files changed, 212 insertions(+), 213 deletions(-) > > > > Making this a bitfield is not worth it. It will necessitate masking > operations on every access to these fields which may increase the size > of .text by more than 96B; it may even be that this more than offsets > the savings of 96B from using a bitfield. Okay, then changed to uint8_t locally. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".