From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7333848A19 for ; Thu, 23 May 2024 07:12:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B0CD868D343; Thu, 23 May 2024 10:12:02 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 379CC68C6D5 for ; Thu, 23 May 2024 10:11:56 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=bwnoKF/9; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EBEFF240DAC for ; Thu, 23 May 2024 09:11:55 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id pljtJ7dgOeaq for ; Thu, 23 May 2024 09:11:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1716448315; bh=STDie44KWRXcgAMwfg92f4URnBungJIxsRYZOtZbYDg=; h=Subject:From:To:In-Reply-To:References:Date:From; b=bwnoKF/9xJve6FvsENjb1EoK0zFDDbCAWsL4s83JU6TMDsC1r667oWyo7iK1R004g SEObg9u9HzaSvn5K5U9IUS/xuNLmUeoe4KnbaZfUKiLFJTbD839GlBcaZmgbqBDGh4 GQtiMgxrEvoyVcR+wgzA4VJ7fJ7j4pGW79GiGTy/vwkQ0wMsitnnNYGui053am1x/p LcnJyhfHBq4WcoBZBEJMXyHwjDqLMCK6sKVUJ+AJeTRTSvBmd2deAT4cfzhsXhG3gq 9uUa5NV41GQq8Q/JGcX5rx6SKCesxuiZAH1rAlLfrYRqkggLbVrgTAHUubHHILoJpU Wudmtwa0qtTaw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 38D7F2404E5 for ; Thu, 23 May 2024 09:11:55 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 1780C1601B9; Thu, 23 May 2024 09:11:55 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240515010829.2667-1-jamrial@gmail.com> References: <20240515010829.2667-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 23 May 2024 09:11:55 +0200 Message-ID: <171644831506.22242.11088844724944878786@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: add a helper function to get the ambisonic order of a layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-05-15 03:08:28) > Signed-off-by: James Almer > --- > libavutil/channel_layout.c | 17 ++++++++--------- > libavutil/channel_layout.h | 10 ++++++++++ > 2 files changed, 18 insertions(+), 9 deletions(-) > > diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c > index fd6718e0e7..e213f68666 100644 > --- a/libavutil/channel_layout.c > +++ b/libavutil/channel_layout.c > @@ -473,15 +473,14 @@ static int has_channel_names(const AVChannelLayout *channel_layout) > return 0; > } > > -/** > - * If the layout is n-th order standard-order ambisonic, with optional > - * extra non-diegetic channels at the end, return the order. > - * Return a negative error code otherwise. > - */ > -static int ambisonic_order(const AVChannelLayout *channel_layout) > +int av_channel_layout_get_ambisonic_order(const AVChannelLayout *channel_layout) IMO the _get_ in the name is just making it unnecessarily longer. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".