From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5E60749D82 for ; Wed, 10 Apr 2024 06:38:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD7F368CFB7; Wed, 10 Apr 2024 09:38:08 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C133B68CCFE for ; Wed, 10 Apr 2024 09:38:02 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=iFPnQVRi; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 703C3240DAC; Wed, 10 Apr 2024 08:38:02 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id AYFhMHHQ7Toi; Wed, 10 Apr 2024 08:38:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1712731080; bh=zZLl455wUaO6sk3BWUe3qDWkAmmlxTzvCOhb0ze90ms=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=iFPnQVRiomJBXOCn2WJiwueX4OENjaRKZlVj5Z8ofYAKNzimXufqk43NfkMMkyrQJ 6Mr/0saHEA4WjEvAMbr3Eber0XXkCB/qtlO39PYj5ug6sbB+eR1nkzblbLwoz5zbDz grTZOok3MAbndGm93XFe1IANH5gE3GBuHkpN9YDJlktlBhRY9yS+DAL3M05wIPgala cNkz0MwlprhMbsG9kEn3iIO4YfsMM7Lq/dW9oYccMmjRDxh8I8sUheKp530/GsSGMg 5rR38jrqIkaUcgmvcVCpN/sPm5jnpO4HhKI9lOwQvka9PUOnjxTlSTehylb50XRtqH 5IhO+87rusuxA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 53A202404E5; Wed, 10 Apr 2024 08:38:00 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2D5651601B9; Wed, 10 Apr 2024 08:38:00 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Wed, 10 Apr 2024 08:38:00 +0200 Message-ID: <171273108015.22242.15506447231425967158@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 01/27] avcodec/threadprogress: Add new API for frame-threaded progress X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-04-08 21:51:59) > +/** > + * ThreadProgress is an API to easily notify other threads about progress > + * of any kind as long as it can be packaged into an int and is consistent > + * with the natural ordering of integers. > + * > + * Each initialized ThreadProgress can be in one of two modes: No-op mode > + * or ordinary mode. In the former mode, ff_thread_report_progress() and > + * ff_thread_await_progress() are no-ops to simply support usecases like > + * non-frame-threading. Only in the latter case perform these functions Maybe 'strictly serial usecases' or 'non-parallel usecases' would sound better. > + * what their name already implies. > + */ > + > +#include > +#include > +#include "libavutil/thread.h" > + > +/** > + * This struct should be treated as opaque by users. > + */ > +typedef struct ThreadProgress { > + atomic_int progress; > + unsigned init; > + AVMutex progress_mutex; > + AVCond progress_cond; > +} ThreadProgress; > + > +/** > + * Initialize a ThreadProgress. > + * > + * @param init_mode If zero, the ThreadProgress will be initialized so that > + * to be in no-op mode as described above. Otherwise Seems like something missing here. LGTM otherwise. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".