From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EB1E049202 for ; Sun, 7 Apr 2024 06:15:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7078468D0E0; Sun, 7 Apr 2024 09:15:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C749368C4F1 for ; Sun, 7 Apr 2024 09:15:20 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=n2/GasD8; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EC933240DAC; Sun, 7 Apr 2024 08:15:19 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id hhPiJAOKtZ9e; Sun, 7 Apr 2024 08:15:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1712470519; bh=InvnqUX8DSJw6IAgZ5pUM5cer0i3uWzF7uUoRFXl+RI=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=n2/GasD8Bjz163rQIvhIHmiDS/wcNyT9Ilt1KPEoMSlBELUYypF3eKIBnOa9jZbM2 xPhOw5mXBivpMNvq56xK/wZZW885dxGAOgX/e53qoK9AXoCxxpw1UnzhaHqgdYRCE6 2qZ3AKrvJQZ+/lsRt/JHusmiDtNt+yrmMWUvigFFC/7vrR4qZQQ5KTisb6x/RwMmZR 56vs90zhyuaUiy1+zscHp86tBlSjAg7KgV/65i0ys0jyPxMbVO6oMXLtAN3pvfpDA4 hwzmu0opQpmY/7nmj2xuXir1hgAh2JdIDeWFxQVV07RvjyVM68tRCKF3x59pqgSHpT ZbY1MLLvRCxtA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0FE792404E5; Sun, 7 Apr 2024 08:15:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id CDF451601B9; Sun, 7 Apr 2024 08:15:12 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240406134546.61454-1-post@frankplowman.com> References: <20240406134546.61454-1-post@frankplowman.com> Mail-Followup-To: FFmpeg development discussions and patches , Frank Plowman Date: Sun, 07 Apr 2024 08:15:12 +0200 Message-ID: <171247051281.28449.5799177261707982675@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Error if SPS ID is duplicated within CVS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Frank Plowman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Frank Plowman (2024-04-06 15:46:09) > Key line from the spec is: > > "All SPS NAL units with a particular value of sps_seq_parameter_set_id > in a CVS shall have the same content." > > Prior to this patch, the VVC decoder's behaviour on encountering a > duplicated SPS ID (within the entire bitstream, not restricted to > a CVS) was simply to replace the entry in the SPS lookup table with the > new data. Illegal bitstreams with multiple SPSs in the same CVS sharing > an ID but differing elsewhere could cause all manner of issues. > > The patch tracks which SPS IDs have been used in the given CVS using the > new sps_id_used field of VVCParamSets. If it encounters an SPS with an > ID already in use and whose content differs from the previous SPS, it > throws an AVERROR_INVALIDDATA. I wonder if it wouldn't be better to do what H264/HEVC do, which is replace the SPS, invalidate the PPSes that depend on the old one, and start a new CVS. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".