From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 41F584A67C for ; Wed, 3 Apr 2024 08:37:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCABB68D0E4; Wed, 3 Apr 2024 11:37:07 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E06CE68CF50 for ; Wed, 3 Apr 2024 11:37:00 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=a03OwVPb; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9ECF1240DAC; Wed, 3 Apr 2024 10:37:00 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 3pYXyMQhkzPl; Wed, 3 Apr 2024 10:37:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1712133420; bh=YR4FjBr52SBQSTB1Kxk4HvJiuJqJpOIMXGmczJyp630=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=a03OwVPbXGE0UZA5EG2FgEaTbHvd35fCpOpU4rhU+n2fDCyUEHraUbrk3QBRexmG0 Qw+72r3uvL8ccojrFFAnzCzmId+OkbyOUQSgJnWhPNjutvr/MG7NoDIGa5vmToLQMC n7N9Eh1KDEwvW6UTr1k3T1fWwxu+AFGgRPSEXdP7TFaVMbRECPMoLkSWir89CLQDu2 N8E5IdIwGgMPUk9frBEaVhLFJNbxSH+SDh7sj2mQ77gukSL8VYzZe4Xa+Nyt4CiAnV VCedb/mHBx+Ry4bwAgO6HbXkkRQzAUAZ7elzr2sHJdGF+NKUmDav550MXVTl5Y+MHb JXwMJ6yKUaDyQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 092982404E5; Wed, 3 Apr 2024 10:37:00 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id ECC0A1601B9; Wed, 3 Apr 2024 10:36:59 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Wed, 03 Apr 2024 10:36:59 +0200 Message-ID: <171213341995.28449.17458538396305228565@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 01/10] avcodec/libvpxenc: Avoid unused-variable warning if VP9 enc is disabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-03-31 07:30:26) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 635cdf7a0e..bcbdc4981e 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -49,6 +49,9 @@ > #include "libavutil/opt.h" > #include "libavutil/pixdesc.h" > > +#define IS_VP9(avctx) (CONFIG_LIBVPX_VP9_ENCODER && avctx->codec_id == AV_CODEC_ID_VP9) > +#define IS_VP8(avctx) (CONFIG_LIBVPX_VP8_ENCODER && avctx->codec_id == AV_CODEC_ID_VP8) > + > /** > * Portion of struct vpx_codec_cx_pkt from vpx_encoder.h. > * One encoded frame returned from the library. > @@ -359,8 +362,7 @@ static int frame_data_submit(AVCodecContext *avctx, AVFifo *fifo, > FrameData fd = { .pts = frame->pts }; > int ret; > > -#if CONFIG_LIBVPX_VP9_ENCODER > - if (avctx->codec_id == AV_CODEC_ID_VP9 && > + if (IS_VP9(avctx) && Weren't we moving towards getting rid of our dependency on DCE? I recall some discussions about this in recent years, though I don't remember if there was a consensus. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".