From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AF5994A485 for ; Thu, 28 Mar 2024 11:40:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CDE2F68D6C3; Thu, 28 Mar 2024 13:40:09 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 406B168D5E2 for ; Thu, 28 Mar 2024 13:40:04 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=JoeBg1Qr; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 071FA240DAC for ; Thu, 28 Mar 2024 12:40:04 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id tE8-OIuKZYtM for ; Thu, 28 Mar 2024 12:40:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711626003; bh=zwNcqNzxRWJSQfi7JFRLo2K4J2+xXgAcSZWZnCk6Ntk=; h=Subject:From:To:In-Reply-To:References:Date:From; b=JoeBg1QrMHzsa/XQUn7aOH+wkvL0gtGqjrdRd8IC5Q5UR90LYz7yySHcJ0JMrMNNU UVDxGihtWdbE0rinA04cykTL4C0g+UEVstiOF112omyVZFYE8Dp7FakIjeWeB0HD0z 873iYKW2FsgAfRqHRyTpmFwrFv4NYrffxxOpiECqHw7g49ybWX/eUr5RMEHDR3686z c/fG4DRPHgUfdlbdiA4lTgcIxuooR5EEqP1NJAaV3h1UlRad9+oVEshcyjGgNLAWof y+Vd9nlZuMEbjvVMUIbi4PdT9r2cCBeQ5JO0ux8DY8B3HbzODrH6RPqJXktT2xcN6N rA/oQAuPt6TxA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 34FDB2404AF for ; Thu, 28 Mar 2024 12:40:03 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 119311601B9; Thu, 28 Mar 2024 12:40:03 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240328031210.21407-1-jamrial@gmail.com> <20240328031210.21407-6-jamrial@gmail.com> <171162556968.7287.5765479778642883211@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 28 Mar 2024 12:40:03 +0100 Message-ID: <171162600304.7287.7459431574454273029@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-28 12:36:37) > On 3/28/2024 8:32 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-28 04:12:09) > >> They will be useful to fill arrays stored in other structs. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec/av1dec.c | 7 +-- > >> libavcodec/cri.c | 3 +- > >> libavcodec/decode.c | 99 +++++++++++++++++++++++++++-------------- > >> libavcodec/decode.h | 28 ++++++------ > >> libavcodec/dpx.c | 3 +- > >> libavcodec/h2645_sei.c | 4 +- > >> libavcodec/h264_slice.c | 3 +- > >> libavcodec/hevcdec.c | 6 ++- > >> libavcodec/libdav1d.c | 7 +-- > >> libavcodec/libjxldec.c | 3 +- > >> libavcodec/mjpegdec.c | 3 +- > >> libavcodec/mpeg12dec.c | 11 +++-- > >> libavcodec/pngdec.c | 8 ++-- > >> libavcodec/qsvdec.c | 4 +- > >> libavcodec/tiff.c | 3 +- > >> libavcodec/webp.c | 3 +- > >> 16 files changed, 120 insertions(+), 75 deletions(-) > > > > Extra churn in all the decoders, longer and harder to read lines. > > Why not make ff_frame_new_side_data_from_buf() a wrapper for a new > > function instead? > > Can you elaborate? I'm making all the decode.h side data wrappers take > pointers to AVFrameSideData instead of AVFrames so they're not limited > to the latter. I mean: * add new function(s) that work with AVFrameSideData; * keep signatures for existing function the same, but change their implementation into a wrapper for the above this way the decoders do not need to be changed. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".