From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames
Date: Thu, 28 Mar 2024 12:32:49 +0100
Message-ID: <171162556968.7287.5765479778642883211@lain.khirnov.net> (raw)
In-Reply-To: <20240328031210.21407-6-jamrial@gmail.com>
Quoting James Almer (2024-03-28 04:12:09)
> They will be useful to fill arrays stored in other structs.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavcodec/av1dec.c | 7 +--
> libavcodec/cri.c | 3 +-
> libavcodec/decode.c | 99 +++++++++++++++++++++++++++--------------
> libavcodec/decode.h | 28 ++++++------
> libavcodec/dpx.c | 3 +-
> libavcodec/h2645_sei.c | 4 +-
> libavcodec/h264_slice.c | 3 +-
> libavcodec/hevcdec.c | 6 ++-
> libavcodec/libdav1d.c | 7 +--
> libavcodec/libjxldec.c | 3 +-
> libavcodec/mjpegdec.c | 3 +-
> libavcodec/mpeg12dec.c | 11 +++--
> libavcodec/pngdec.c | 8 ++--
> libavcodec/qsvdec.c | 4 +-
> libavcodec/tiff.c | 3 +-
> libavcodec/webp.c | 3 +-
> 16 files changed, 120 insertions(+), 75 deletions(-)
Extra churn in all the decoders, longer and harder to read lines.
Why not make ff_frame_new_side_data_from_buf() a wrapper for a new
function instead?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-28 11:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 3:12 [FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries James Almer
2024-03-28 3:12 ` [FFmpeg-devel] [PATCH 2/7 v4] avutil/frame: add helper for adding side data w/ AVBufferRef to array James Almer
2024-03-28 11:27 ` Anton Khirnov
2024-03-28 11:49 ` James Almer
2024-03-28 12:19 ` Anton Khirnov
2024-03-28 14:00 ` James Almer
2024-03-28 3:12 ` [FFmpeg-devel] [PATCH 3/7 v4] avutil/frame: use the same data pointer as the source entry when cloning side data James Almer
2024-03-28 11:29 ` Anton Khirnov
2024-03-28 11:33 ` James Almer
2024-03-28 11:37 ` Anton Khirnov
2024-03-28 3:12 ` [FFmpeg-devel] [PATCH 4/7 v4] avutil/frame: add helper to remove side data of a given type from an array James Almer
2024-03-28 3:12 ` [FFmpeg-devel] [PATCH 5/7 v4] avutil/mastering_display_metadata: add a new allocator function that returns a size James Almer
2024-03-28 3:12 ` [FFmpeg-devel] [PATCH 6/7 v4] avcodec/decode: make the AVFrameSideData helper wrappers not depend on frames James Almer
2024-03-28 11:32 ` Anton Khirnov [this message]
2024-03-28 11:36 ` James Almer
2024-03-28 11:40 ` Anton Khirnov
2024-03-28 3:12 ` [FFmpeg-devel] [PATCH 7/7 v4] avcodec/hevcdec: export global side data in AVCodecContext James Almer
2024-03-28 11:23 ` [FFmpeg-devel] [PATCH 1/7 v4] avutil/frame: add a flag to allow overwritting existing entries Anton Khirnov
2024-03-28 11:41 ` James Almer
2024-03-28 12:21 ` Anton Khirnov
2024-03-28 12:57 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171162556968.7287.5765479778642883211@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git