From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/demux: stop calling avcodec_close()
Date: Thu, 28 Mar 2024 09:02:29 +0100
Message-ID: <171161294953.7287.7421530414842845195@lain.khirnov.net> (raw)
In-Reply-To: <CAK+ULv6b-UTkiP65DZb6C6BynPiVUvPqWaCe6xfEDs78FRSnWQ@mail.gmail.com>
Quoting Kieran Kunhya (2024-03-27 15:13:12)
> On Wed, 27 Mar 2024 at 14:03, Michael Niedermayer <michael@niedermayer.cc>
> wrote:
>
> > On Fri, Feb 09, 2024 at 03:19:58PM +0000, Anton Khirnov wrote:
> > > ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Thu Feb
> > 1 08:57:24 2024 +0100| [ca18bb597223b3df5bbf8a1836d157ba58b62570] |
> > committer: Anton Khirnov
> > >
> > > lavf/demux: stop calling avcodec_close()
> > >
> > > Replace it with recreating the codec context.
> > >
> > > This is the last remaining blocker for deprecating avcodec_close().
> > >
> > > >
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ca18bb597223b3df5bbf8a1836d157ba58b62570
> > > ---
> > >
> > > libavformat/demux.c | 61
> > ++++++++++++++++++++++++++++++++++++++++++++++++-----
> > > 1 file changed, 56 insertions(+), 5 deletions(-)
> >
> > This breaks ffprobe "Closed Caption" output
> > before:
> > Stream #0:2[0x1e0]: Video: mpeg2video (Main), yuv420p(tv, progressive),
> > 1920x1080 [SAR 1:1 DAR 16:9], Closed Captions, 29.97 fps, 59.94 tbr, 90k tbn
> >
>
> Closed Captions are sparse side data, we shouldn't be exposing it like this
> to begin with.
+1
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-03-28 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240209151959.C7231411B5B@natalya.videolan.org>
2024-03-27 14:03 ` Michael Niedermayer
2024-03-27 14:13 ` Kieran Kunhya
2024-03-27 14:30 ` James Almer
2024-03-28 8:02 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171161294953.7287.7421530414842845195@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git