From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 8B5B84A3BF
	for <ffmpegdev@gitmailbox.com>; Wed, 27 Mar 2024 12:41:10 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7894F68D65A;
	Wed, 27 Mar 2024 14:41:07 +0200 (EET)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B8CFA68D5AC
 for <ffmpeg-devel@ffmpeg.org>; Wed, 27 Mar 2024 14:41:00 +0200 (EET)
Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key;
 unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256
 header.s=mail header.b=mYcW2n1M; dkim-atps=neutral
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id 68F77240DAC
 for <ffmpeg-devel@ffmpeg.org>; Wed, 27 Mar 2024 13:41:00 +0100 (CET)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP
 id DOpJnxOY-mPz for <ffmpeg-devel@ffmpeg.org>;
 Wed, 27 Mar 2024 13:40:59 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail;
 t=1711543259; bh=k3sPMa0cu4VUl0AOX2UuCJPv+5+bKPuVMAidQyDjPjw=;
 h=Subject:From:To:In-Reply-To:References:Date:From;
 b=mYcW2n1MAlXitGlp8ZpFEz/772SlfR45fQyYmcQVdHj//7W/BuL0P1NS0mls/oa3b
 vDf0++q03TbF0zvADK7/rS/1ir3GroyaUmMEhrt6i83CgjBXkmZvLcDhmWy3Pa5jWD
 I7rYv4xA2KPaUyOp4spTHeREejvMmDwhpuAyhjQuHp68BuXDw8fhvWAr7y56/jYGWW
 0caU+4Pq4maLbEUn+v1th6Ceq0oGVS+IzRB7i8+2hh916GZaZPAb2IhHgoWdTi0NmV
 dz0022fjWal4/jSYDXsO9Nt9ILZloU6NnskuE4AQ5VroreFE5hbPBFIa8WhHTmDGZn
 +YgIF2Ik1VhGQ==
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id D44BA2404AF
 for <ffmpeg-devel@ffmpeg.org>; Wed, 27 Mar 2024 13:40:59 +0100 (CET)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id B14C41601B9; Wed, 27 Mar 2024 13:40:59 +0100 (CET)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <7f5602ce-0326-44ce-99b5-b7ff4fc24190@gmail.com>
References: <20240325200602.63020-1-jamrial@gmail.com>
 <20240325200602.63020-4-jamrial@gmail.com>
 <GV1P250MB07371F82E2AEB6DA4315E8218F362@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
 <f77f1819-3ed6-4d16-8f39-40c986394cfb@gmail.com>
 <GV1P250MB07371526EE42E2C2BD633A088F362@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
 <b11368a2-9476-46fc-9774-a847b86b8246@gmail.com>
 <171152531453.7287.8553456080667008312@lain.khirnov.net>
 <7f5602ce-0326-44ce-99b5-b7ff4fc24190@gmail.com>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Wed, 27 Mar 2024 13:40:59 +0100
Message-ID: <171154325969.7287.3577300184736876535@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 4/6 v2]
 avutil/mastering_display_metadata: add a new allocator function that
 returns a size
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/171154325969.7287.3577300184736876535@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting James Almer (2024-03-27 13:35:35)
> On 3/27/2024 4:41 AM, Anton Khirnov wrote:
> > Quoting James Almer (2024-03-25 22:13:25)
> >> On 3/25/2024 6:02 PM, Andreas Rheinhardt wrote:
> >>> James Almer:
> >>>> I don't mind a function like that being added to simplify future
> >>>> additions, but this API is orthogonal to the frame side data one. It's
> >>>> also used in packets, for example, and right now lavf is using
> >>>> sizeof(AVMasteringDisplayMetadata) because
> >>>> av_mastering_display_metadata_alloc() is not useful.
> >>>>
> >>>
> >>> The API proposed by me is supposed to make API like
> >>> av_mastering_display_metadata_alloc_size() redundant and therefore these
> >>> two additions are not orthogonal.
> >>
> >> Just because there's a frame side data type for MDM does not make the
> >> new alloc function redundant.
> > 
> > The commit message says:
> > 
> >> av_mastering_display_metadata_alloc() is not useful in scenarios where you need to
> >> know the runtime size of AVMasteringDisplayMetadata.
> > 
> > In what scenarios besides side data do you need to know the size of this
> > struct?
> 
> None within our libraries that i can think of, but library users can 
> have scenarios we need to provide for. MDM is a standalone API, so lets 
> not try to make its usability depend on a separate one.
> I'm replacing a helper with a better one, it should not be so controversial.

Breaking API to benefit hypothetical use cases IS a controversial change
in my view.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".