From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0F5354A3BA for ; Wed, 27 Mar 2024 12:26:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F38668D657; Wed, 27 Mar 2024 14:26:04 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ABE2468D410 for ; Wed, 27 Mar 2024 14:25:57 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=rgPHH+01; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5C998240DAC for ; Wed, 27 Mar 2024 13:25:57 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id jxOvpT5nOq3D for ; Wed, 27 Mar 2024 13:25:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711542356; bh=sjXhlwx5bbNwshoc2WZ5fJ/hduzDSLPUnNfxnusjtg8=; h=Subject:From:To:In-Reply-To:References:Date:From; b=rgPHH+01xpVrOuafudrVKtb7/eiQ/YSCAUbkM6URcdsVUJ2AngrL94ov9s71FbgrG 1NKEdkAUCCbO39XEnTi6QoluntRnXS7aN9v5h/UOuM0QgnKt7/MAwO5ogL/Thj0jm4 536VJInDqnYblsT5qIPseoEfVU3qDxyXqsBA/kX3nCMWutbz6oC6vDbGU8M5GmwJtn AIGs0k8w4g55dvjQjUPLH5OEuoGBsoldj2zzUH67zXkdZyn2J110L7QR91bsZlPqbd icuDJiW+GZp+hrR53WfA0MXpeRLd06hu2pwLJ8fsjNxdpngzHmcOCvFpeKM3gWRkBq v0Q538ELMgFWw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B5A892404AF for ; Wed, 27 Mar 2024 13:25:56 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 931621601B9; Wed, 27 Mar 2024 13:25:56 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <2ab7ec0b-20db-411e-a4e3-543c69bc9b9d@gmail.com> References: <20240325200602.63020-1-jamrial@gmail.com> <171152675176.7287.1643281874746299286@lain.khirnov.net> <2ab7ec0b-20db-411e-a4e3-543c69bc9b9d@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 27 Mar 2024 13:25:56 +0100 Message-ID: <171154235658.7287.14399846525533726713@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/6 v2] avutil/frame: add a flag to not create duplicate entries in a side data array X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-27 12:49:49) > > * T does have a MULTI prop, then user decides whether to replace, > > add, or do nothing > > > > I think the default behaviour for MULTI types should be adding, and the > > other two cases should be covered by the user explicitly. > > > > Then we only need a single flag, which only applies to non-MULTI types, > > and chooses whether to replace or not. > > I don't follow. How does a single flag let you choose between all these > scenarios? I doesn't, my point is that for MULTI types the functions should always add a new instance, because very few scenarios need anything else. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".