From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1426649A03 for ; Wed, 27 Mar 2024 07:42:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 564D368D61F; Wed, 27 Mar 2024 09:42:02 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8417468C444 for ; Wed, 27 Mar 2024 09:41:55 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=nd7ykyNE; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4B1E9240DAC for ; Wed, 27 Mar 2024 08:41:55 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id FoWRx4_-tmgZ for ; Wed, 27 Mar 2024 08:41:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711525314; bh=0Z8/xbKuELqBL+dL7c6JW3+Ws8HrGVHD4C68ghdhgR4=; h=Subject:From:To:In-Reply-To:References:Date:From; b=nd7ykyNEgyMCKCHuifZcSY/kQKIABYAswPV/nsn3pedNK3ul83rzFFPGhmv966Sqh PzydeMJwq6TFzduZ6eN6HpqmOn2/Czlqg5Evg5XyxrlCoMkgnkFLDVQnNADwAcim/8 EdwzQJ4yyXbui841cX19NSOUxxd7/Kc6GuF1UOKXt7RMwJkUw9OEmBczJj09nVKZzc Uib+zpnkETG2pY48tvhy/ZFA+eOqHmiVb62TJBwMLAHQziOBQidDUoE5lHJVtgKx2N AQURvQp3uioYY6jr+UqbzgfrGdhnCLnhd/61NV1AzP54DCclbkgGh6W5YeEPAi5Veg GnV+6o90EUlJQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9C15D2404AF for ; Wed, 27 Mar 2024 08:41:54 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 882551601B9; Wed, 27 Mar 2024 08:41:54 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240325200602.63020-1-jamrial@gmail.com> <20240325200602.63020-4-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 27 Mar 2024 08:41:54 +0100 Message-ID: <171152531453.7287.8553456080667008312@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/6 v2] avutil/mastering_display_metadata: add a new allocator function that returns a size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-25 22:13:25) > On 3/25/2024 6:02 PM, Andreas Rheinhardt wrote: > > James Almer: > >> I don't mind a function like that being added to simplify future > >> additions, but this API is orthogonal to the frame side data one. It's > >> also used in packets, for example, and right now lavf is using > >> sizeof(AVMasteringDisplayMetadata) because > >> av_mastering_display_metadata_alloc() is not useful. > >> > > > > The API proposed by me is supposed to make API like > > av_mastering_display_metadata_alloc_size() redundant and therefore these > > two additions are not orthogonal. > > Just because there's a frame side data type for MDM does not make the > new alloc function redundant. The commit message says: > av_mastering_display_metadata_alloc() is not useful in scenarios where you need to > know the runtime size of AVMasteringDisplayMetadata. In what scenarios besides side data do you need to know the size of this struct? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".