Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps
Date: Wed, 27 Mar 2024 08:39:17 +0100
Message-ID: <171152515798.7287.8979021106267679923@lain.khirnov.net> (raw)
In-Reply-To: <20240322230818.18997-1-michael@niedermayer.cc>

Quoting Michael Niedermayer (2024-03-23 00:08:16)
> Fixes: Timeout
> Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/cafdec.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
> index 426c56b9bd..334077efb5 100644
> --- a/libavformat/cafdec.c
> +++ b/libavformat/cafdec.c
> @@ -33,6 +33,7 @@
>  #include "isom.h"
>  #include "mov_chan.h"
>  #include "libavcodec/flac.h"
> +#include "libavcodec/internal.h"
>  #include "libavutil/intreadwrite.h"
>  #include "libavutil/intfloat.h"
>  #include "libavutil/dict.h"
> @@ -87,6 +88,10 @@ static int read_desc_chunk(AVFormatContext *s)
>      st->codecpar->ch_layout.nb_channels = avio_rb32(pb);
>      st->codecpar->bits_per_coded_sample = avio_rb32(pb);
>  
> +    if (st->codecpar->ch_layout.nb_channels > FF_SANE_NB_CHANNELS ||

I dislike this.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".