From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2CEB948C7F for ; Sun, 24 Mar 2024 10:34:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2428B68D3C7; Sun, 24 Mar 2024 12:34:00 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C93A668D33C for ; Sun, 24 Mar 2024 12:33:53 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=JnB5qTH6; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7E18B240DAC for ; Sun, 24 Mar 2024 11:33:53 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id gf09BnX3To7r for ; Sun, 24 Mar 2024 11:33:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711276432; bh=iYRmBjuXL8V6p71lCrywFv9XjYuE4QQspDkjK1qcSb0=; h=Subject:From:To:In-Reply-To:References:Date:From; b=JnB5qTH6ulKFnVVyMYIcOcJDATJWbUCJ522M/lguCIwp8hm2Y5EpNKMwNEC2NfYoE MGJ7rnnD5jxEkmLAujtgQxBFK2Ron9ZZHyZY/z6LfuajfbZO/rik6AvXDBNHMW0hTz q865HbN1IVPaLSMBAvjZylLb8QmTYwZuLIsdLZufy8H1viM4UoXIvtqF7x5Lpa7uCs eB5HONXLnRnOXFQt4J4zkCm2Lzn/jJRUH1gdLbYsKmjE+y7MJbAjyuSCNaugxcBXqY uXK9IPCbMa353lh8KydwqCFtGgzacvg/myj8XO+s2l03n0jIaR19yGEw/PsdLezr0t aDg2viccpegXA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BA4EB2404AF for ; Sun, 24 Mar 2024 11:33:52 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 98A731601B9; Sun, 24 Mar 2024 11:33:52 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240323140054.4222-1-anton@khirnov.net> <171127245802.7287.14513769027741252141@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 24 Mar 2024 11:33:52 +0100 Message-ID: <171127643259.1646.17791906321816556629@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-03-24 11:19:19) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-23 15:11:59) > >> 1. The earlier code would just work in case the user used a smaller > >> number of elements for the matrices if these matrices were not used at > >> all (which happens for the majority of encoders). This is no longer true > >> with this patch. > > > > So? > > > > It means there is a scenario where you break something. There is no way for the caller to know whether, and how much, will lavc read from those tables, so it's invalid API use. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".