From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 979124A198 for ; Sat, 23 Mar 2024 13:19:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA7C068D526; Sat, 23 Mar 2024 15:19:24 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5BC3E68D219 for ; Sat, 23 Mar 2024 15:19:18 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Tq95fYVr; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7AEBD240DAC for ; Sat, 23 Mar 2024 14:19:17 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id n_jgYSf5E71t for ; Sat, 23 Mar 2024 14:19:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711199956; bh=6Y/AgWoDLEnfmbiGYjqiLIlh/h0DAl5GxGHGR3KpNoM=; h=Subject:From:To:In-Reply-To:References:Date:From; b=Tq95fYVrp9/ksjW5Xa+LtdDLEw/TIAt65QViF31S8ppsrLsSU7DgIcxliYuRdGY4/ qKUHpElWr0Krk9XFdCHaruAOG65MK/nAZWs0dc0P0Lf7Q5qlgqbP6kobxtTcGTaFgy adFm28oAgzO7GJp4jCJEgRjLTZD1RhROyZFnjlABRKEwB4j3gtqQFyadYxJ+CDHkDl w+GSxidaydtK/S8IiGMGtTb1LNtZFRRyYRdVD7b7z0HOgGMhUVJvYn8P8eY5cYm2N8 4yy4XdhiCLr/wcEnPWlAHIgbw2xO/UI+dgRBMTLpsqCaPVwYE65bOacP2oXlHhkQwr St9QcDjoVxu6Q== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D43822404AF for ; Sat, 23 Mar 2024 14:19:16 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id AA42E1601B9; Sat, 23 Mar 2024 14:19:10 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240323130409.20925-1-anton@khirnov.net> <20240323130409.20925-2-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 23 Mar 2024 14:19:10 +0100 Message-ID: <171119995067.1646.11310285146493611311@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg_enc: only promote first frame side data to global when meaningful X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-03-23 14:15:06) > Anton Khirnov: > > Skip those side data types that do not make sense as global side data. > > --- > > fftools/ffmpeg_enc.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c > > index f01be1c22f..6a91fd0398 100644 > > --- a/fftools/ffmpeg_enc.c > > +++ b/fftools/ffmpeg_enc.c > > @@ -247,6 +247,11 @@ int enc_open(void *opaque, const AVFrame *frame) > > enc_ctx->chroma_sample_location = frame->chroma_location; > > > > for (int i = 0; i < frame->nb_side_data; i++) { > > + const AVSideDataDescriptor *desc = av_frame_side_data_desc(frame->side_data[i]->type); > > + > > + if (!desc || !(desc->props & AV_SIDE_DATA_PROP_GLOBAL)) > > + continue; > > Why the first check? Is it intended that a defined side data type > doesn't have a descriptor? Because IIRC all side data types that can > occur here are defined and have not been created by letting the user > pass a number via options. It shouldn't happen, but it's not inconceivable that e.g. a filter could attach side data with an unknown type to a frame. I can remove the check if you prefer it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".