From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E088C4A15D for ; Fri, 22 Mar 2024 21:11:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2152468D473; Fri, 22 Mar 2024 23:11:32 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BF31268D40F for ; Fri, 22 Mar 2024 23:11:25 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=GkcvqBYy; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 78F54240DAC for ; Fri, 22 Mar 2024 22:11:25 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id q9GEQDjTa63c for ; Fri, 22 Mar 2024 22:11:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711141884; bh=U/r3KRxtHPYa1dHscb0YS86LJJWCLcwLjqMsIy3L+Fc=; h=Subject:From:To:In-Reply-To:References:Date:From; b=GkcvqBYy8Tt+g7v6R5eZDjEeroxWVkG0mTfjfXSKmvcZrd6Wba1ETAeNwcp+yIx2h D+wJL9sMVb1bp/N+WMLIO1QdWLmnJ2tKkvV2Qbqa9uznkk23M0hLAnKiA2heY0JdjP N0XQEhtQMkqHMxY4e/Vx1Hwy/5IS7Fc6hrsjTr3J2lAllph01Kk2b50noyytm8ZjEl nS0dJAqkFrg4/OYhFxIc1Q3eLFNWdcPK0kb74Wt6Wutk8RFpYXb+QDP+bS6Lm68D2o RMjAdBGmYHUCCPzCu8fegfVM1TD/QRiJxos/8WAIw5L4TFb15a5cnG8Nt6g+Y2Jp3g DTR0P0Yo07ohg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BA59C2404AF for ; Fri, 22 Mar 2024 22:11:24 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 98FA31601B9; Fri, 22 Mar 2024 22:11:24 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <3a966dd3-ee38-442e-ad43-108f849c4556@gmail.com> References: <20240320173150.6A520412633@natalya.videolan.org> <171110112517.7287.14787984561092623515@lain.khirnov.net> <3a966dd3-ee38-442e-ad43-108f849c4556@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 22 Mar 2024 22:11:24 +0100 Message-ID: <171114188459.1646.3162638779523634442@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] ffmpeg: pass first video AVFrame's side data to encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-22 20:38:38) > On 3/22/2024 6:52 AM, Anton Khirnov wrote: > > I objected to this indiscriminate copying in a previous review. > > > > There is no reason to expect side data to apply to the whole stream just > > because it happens to apply to the first frame. For many side data types > > it does not even make sense, as they are fundamentally per-frame. > > So this would need to be handled by having decoders export global side > data in decoded_side_data directly, so there's no need to take them from > frames here (which would include per frame side data, like hdr10 and > closed captions), right? That's not enough, you still need to propagate this data through the filtergraph. I'm leaning towards something like a side data descriptor, that would tell callers (among other things) whether a side data type is meaningful in global headers. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".