From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [RFC] Channels
Date: Fri, 22 Mar 2024 11:29:31 +0100
Message-ID: <171110337183.7287.5315420652895026978@lain.khirnov.net> (raw)
In-Reply-To: <20240322022525.GB6420@pb2>
Quoting Michael Niedermayer (2024-03-22 03:25:25)
> Hi all
>
> we have code like
> st->codecpar->ch_layout.nb_channels = avio_rb32(pb);
>
> and then somewhere there is some code that uses this by first allocating
> an array and that then hits OOM
> (it was this here:
> map = av_calloc(nb_channels, sizeof(*channel_layout->u.map));)
>
> is anyone against adding a max_channels field to AVFormatContext or something
> like that ?
I am.
> alternative is "wont fix" for all such cases,
IMO it's not, in general, a bug, so EWONTFIX is the appropriate
response. If the user does not want us to do arbitrarily large
allocation, they have the appropriate OS-level mechanisms (e.g. ulimit,
cgroups on Linux) or av_max_alloc().
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-22 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 2:25 Michael Niedermayer
2024-03-22 2:59 ` James Almer
2024-03-22 20:58 ` Michael Niedermayer
2024-03-22 10:29 ` Anton Khirnov [this message]
2024-03-27 21:54 ` Michael Niedermayer
2024-03-28 7:02 ` Anton Khirnov
2024-03-28 10:36 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171110337183.7287.5315420652895026978@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git