From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 047DD49852 for ; Thu, 21 Mar 2024 10:17:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 570FE68D52B; Thu, 21 Mar 2024 12:17:13 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3CA8568D392 for ; Thu, 21 Mar 2024 12:17:07 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=H/+IQ7ax; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A131D240DAC; Thu, 21 Mar 2024 11:17:05 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id W38f1IgytWgO; Thu, 21 Mar 2024 11:17:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1711016224; bh=cq18gYMrgB1PUuaLUHDxdg3RtWnDuz7Pdv7XYVEgsZQ=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=H/+IQ7axJTFwmAKCV+FQRZrAXhX0NfW9aAmG530jhmrdLhoCXMo9J4yuNLwEHNsqn zHTpPNxgJcEt1CfgIb/Jj9OjkPiUbwX1Cxt02Rnc6PZlwkcYno7KQIp6ZiFkmP1hGp 1S3y0TsATNelvnirfXRElfUmPTj3IpN8OckOQTbu66CU9b0U8zm4uz2y9EXuZksUBY kO/lbln1/D6XN/Akn+xucoLESPVmPbCL6I2Tic8+M4yMfJ7FPsfcvBtC/FpCmajB4C Fh2OS3rleJvRYUtvrP5D6VwNBLyGakBsFlAm+a/N8t5X3Rg5tq/e6T9tuuOkaejFuq SG7ePuIoz/3ow== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id EB72A2404AF; Thu, 21 Mar 2024 11:17:04 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id EA7AE1601B9; Thu, 21 Mar 2024 11:16:57 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240319191642.95217-1-ffmpeg@haasn.xyz> References: <20240319191642.95217-1-ffmpeg@haasn.xyz> Mail-Followup-To: FFmpeg development discussions and patches , Niklas Haas Date: Thu, 21 Mar 2024 11:16:57 +0100 Message-ID: <171101621793.7287.2859730890037554804@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/4] fftools/ffmpeg_enc: strip DOVI config record for AV1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Niklas Haas (2024-03-19 20:16:39) > From: Niklas Haas > > AV1 streams don't use configuration records, so delete them when > encoding to AV1. Ideally this would be, as the comment suggests, handled > at the frame-level (and stripped by the av1 encoder), but given the > status quo of copying the packet-level data here directly, we should > definitely make an effort to strip it. > --- > fftools/ffmpeg_enc.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) I'm very much not a fan of having codec-specific code in ffmpeg CLI. It implies that every single caller must now be aware of this (undocumented?) interaction of this specific side data with this specific codec ID. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".