From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7454F49E14 for ; Tue, 12 Mar 2024 10:12:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A54F768CF01; Tue, 12 Mar 2024 12:12:44 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B7E468CFDA for ; Tue, 12 Mar 2024 12:12:38 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=acUwwcB0; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D1F44240DAE for ; Tue, 12 Mar 2024 11:12:37 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id UZkCGcKnHmL8 for ; Tue, 12 Mar 2024 11:12:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1710238357; bh=fdFZ4Us/BlB0WhY+zG2LMDDgozo0XjiNjnqoW3nUDEg=; h=Subject:From:To:In-Reply-To:References:Date:From; b=acUwwcB02Qo2Uy3RZUtINmalth6WGMrtyuL1b60KnNFoGQMLwQ50fHRoR0ZbeaoIO bShpRJ0FOQ4V8YjFJ+PjBYnaE1OfIvm5wi+XUXMug6pa2o4b48YsLAyRmU5tTp9Tgu nxptB4NHmA3Xy8va5M45f45nWAomHFr3ejN0IQGu4wnPFGqjDeUCGFNbrYx0hDosSs agFsNooL3bTULQ6kNduVbkS2d7+vjyW4A8vO8TGe8pa2wTBUW4iz2OlnKIWC5Qw5A2 5IvIK2/FkjZkFHtdhoXFqxdpSnmwwf+/48x2TTK0KIYGLHzucKja6wV7T4vC7k38tG gXZsTXGWtjVew== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 084BF240DAC for ; Tue, 12 Mar 2024 11:12:37 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D6ABA1601B9; Tue, 12 Mar 2024 11:12:36 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240312084343.18441-1-anton@khirnov.net> <171023422319.7287.11903630014703761101@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 12 Mar 2024 11:12:36 +0100 Message-ID: <171023835685.662.14765949974652498933@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavu/attributes: add ff_ prefix to attribute_deprecated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-03-12 10:21:52) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-12 09:56:46) > >> Anton Khirnov: > >>> Otherwise it might conflict with caller-defined identifiers. > >>> > >>> ff because it is not supposed to be used by external callers. > >>> --- > >> > >> This is public, so it should be av_attribute_deprecated. > > > > As the commit message says, this is not supposed to be used by external > > callers. Or do you see any reason why it should be public? > > > > It is public given that it is declared in a public header. That is what > matters. I agree that it is (implicitly) public now, but the question is whether it should be. IMO it should not. Do you disagree? > Furthermore, we have used the FF_ and AV_ prefixes for public macros and > the av_ prefix for public symbols, but IIRC we do not use the ff_ prefix > for public symbols at all, therefore I'd like us not to reserve another > namespace. We do reserve the ff namespace for private identifiers that need to be exposed, e.g. in public headers or when linking statically. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".