From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2E5F749DF5 for ; Tue, 12 Mar 2024 09:03:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E350668D121; Tue, 12 Mar 2024 11:03:52 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3CD5E68D011 for ; Tue, 12 Mar 2024 11:03:46 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=QbfEOXC8; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 19F2B240DAE for ; Tue, 12 Mar 2024 10:03:45 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id GQT-fPQe9POe for ; Tue, 12 Mar 2024 10:03:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1710234224; bh=b1x/rdg3B0R1bAMkE7W+VZiVRJ9jF75t1Ax4QNK4614=; h=Subject:From:To:In-Reply-To:References:Date:From; b=QbfEOXC88lOhOhTLmxYcBZ+6wLCZDLjAYZTrsz+o+SfmARQcAiTg6zgwRFErMQSoI BtP5xGF/xsbJ3ctBmWBoEwi4Ez4Y2AA7nE0K/u8F3G42pYYxwfzn9XSYgLW4aD8/qd xaHHt8w9AcmyKg055CKnj/Cqn0TchPtF4NfhONtuj6W8BPJMwhucLaHU8CefIoYIdB ysZKD0t+eNYkY7TNW6+Kpy6gcT8GfG00JP/C+i9JOo1hYVF1RzrzGz26YaPHO7ibqJ bpBckjeOT/rGDZZ4uc9JaFubBptKA/55G1qeVJBbWODWidB+F3GMzHIvHPEGw7RlKh BWeOxPdZWVSNg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 705D4240DAC for ; Tue, 12 Mar 2024 10:03:44 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 36DCF1601B9; Tue, 12 Mar 2024 10:03:43 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240312084343.18441-1-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 12 Mar 2024 10:03:43 +0100 Message-ID: <171023422319.7287.11903630014703761101@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavu/attributes: add ff_ prefix to attribute_deprecated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-03-12 09:56:46) > Anton Khirnov: > > Otherwise it might conflict with caller-defined identifiers. > > > > ff because it is not supposed to be used by external callers. > > --- > > This is public, so it should be av_attribute_deprecated. As the commit message says, this is not supposed to be used by external callers. Or do you see any reason why it should be public? > For the same reason it is actually an API break to no longer provide the > un-prefixed version. I am still providing the unprefixed version under a deprecation guard. > Is this just a general precaution or did you run into an actual conflict? The former. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".