From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 625F146228 for ; Mon, 11 Mar 2024 12:24:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 050C768CF3E; Mon, 11 Mar 2024 14:24:08 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BDC3468B6F9 for ; Mon, 11 Mar 2024 14:24:01 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=HnrJBJdO; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4292E240DAC for ; Mon, 11 Mar 2024 13:24:01 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id MAY1ax2OIvQt for ; Mon, 11 Mar 2024 13:24:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1710159840; bh=b7Rm5Ak1nxyD6DIZjejOkpVA6qD6g8jJJNa1u/W5NSU=; h=Subject:From:To:In-Reply-To:References:Date:From; b=HnrJBJdOK3EVhrBfeeFZdYQ6hvEuDFTmlPHRPq1AXDCCW0f/3wzuJdKxlE9PbcGWC 3ELhKlNByfKea8aODsLWo9ueXnjA0pQ41Crw0qWakbfbuHyupIPO2j9YJEPFq1zrZc xWMHjQuuyk92xnsI7G+uXiEdiFS164veX++mvCbfBzYRkzAo2VXn9WjKwhKQGaO6Kh yeIFw4Xoq9BMslwTPtJ34UJzTekqUhX0Toqg8Lq6ogWr1TJ4f5ZGavwnC+s8SiXzQS LesHWR5oNrXC6n8wGYvVyA6O4kcG087Dt1uGNbUPW6Nud+yzkL5Ju2m441G9ShlqFF rTpSPKxWFUJAA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 7BE2924048D for ; Mon, 11 Mar 2024 13:24:00 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id A121B1601B9; Mon, 11 Mar 2024 13:23:52 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <8e8947e3-b54b-4ce7-864a-13ccf4c4bfd3@noa-archive.com> References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> <20240307203739.GI6420@pb2> <170987607651.7287.4766174024309496140@lain.khirnov.net> <20240310033629.GM6420@pb2> <171005119864.662.10837664362214202636@lain.khirnov.net> <20240310192147.GQ6420@pb2> <171010947057.7287.8642196154964262055@lain.khirnov.net> <7d011f1c-f131-412c-85ce-318c71efba0f@gmail.com> <171011095238.7287.16406128798977096207@lain.khirnov.net> <8e8947e3-b54b-4ce7-864a-13ccf4c4bfd3@noa-archive.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 11 Mar 2024 13:23:52 +0100 Message-ID: <171015983262.662.304106510805949905@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Tobias Rapp (2024-03-11 11:12:38) > On 10/03/2024 23:49, Anton Khirnov wrote: > > > Quoting James Almer (2024-03-10 23:29:27) > >> On 3/10/2024 7:24 PM, Anton Khirnov wrote: > >>> Quoting Michael Niedermayer (2024-03-10 20:21:47) > >>>> On Sun, Mar 10, 2024 at 07:13:18AM +0100, Anton Khirnov wrote: > >>>>> Quoting Michael Niedermayer (2024-03-10 04:36:29) > >>>>>> why not automatically choose a supported timebase ? > >>>>>> "[mpeg4 @ 0x55973c869f00] timebase 1/1000000 not supported by MPEG 4 standard, the maximum admitted value for the timebase denominator is 65535" > >>>>> Because I don't want ffmpeg CLI to have codec-specific code for a codec > >>>>> that's been obsolete for 15+ years. One could also potentially do it > >>>>> inside the encoder itself, but it is nontrivial since the computations > >>>>> are spread across a number of places in mpeg4videoenc.c and > >>>>> mpegvideo_enc.c. And again, it seems like a waste of time - there is no > >>>>> reason to encode mpeg4 today. > >>>> This is not mpeg4 specific, its just a new additional case that fails > >>> The case you reported is mpeg4 specific. > >>> > >>>> ./ffmpeg -i mm-small.mpg test.dv > >>>> [dvvideo @ 0x7f868800f100] Found no DV profile for 80x60 yuv420p video. Valid DV profiles are: > >>> There is no mechanism for an encoder to export supported time bases. > >> Could it be added as an extension to AVProfile, or AVCodec? > > The two cases are actually pretty different: > > * mpeg4 has a constraint on the range of timebases, and actually does > > some perverted computations with the timestamps > > * DV just needs your video to be CFR, with a list of supported > > framerates; dvenc should probably read AVCodecContext.framerate > > instead of time_base > > > > But most importantly, is there an actual current use case for either of > > those encoders? They have both been obsolete for close to two decades. > > It seems silly to add new API that won't actually be useful to anyone. > > Hardware doesn't get outdated as quickly as software. And there are > people that do not switch their full environment to a new codec every > decade just to be "in line". And your point is...? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".