From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 828964754C for ; Sun, 10 Mar 2024 22:24:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6989968CD77; Mon, 11 Mar 2024 00:24:40 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 700DA68CC0A for ; Mon, 11 Mar 2024 00:24:33 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=RUmGPqAe; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7338D24048D for ; Sun, 10 Mar 2024 23:24:32 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id L9-kxvBFJnjs for ; Sun, 10 Mar 2024 23:24:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1710109471; bh=jkoMI8kA+L5G52yqPC3i/53H6UjvjL1x36IBNEUoLhA=; h=Subject:From:To:In-Reply-To:References:Date:From; b=RUmGPqAe7s2RE8Cvjad1dV7SERpCxBDnXfUiOKOV5xet7VbkI0WW5OWiSO2oAyqrI V0tC2EV51Uctfx8ZU62EQVtMdk1+uWr7+Le/QlSNN8UcCVgrYc3pJcmZLFnM3V8Cpb txzWFncrNLc0hUMUgTDnhFc/Ua2+frVyHyn13lJg60AByOCd6EWjQ8hdHD2nNR2T7P okm2Ybf/sK0hl1MrEpfFjWWFOrdo4quy86I6+sHo+qDMYjC3i8x5u0YIkI5PYayFqX oj0WXWfIzB1N1H7B45taR6FbugQNKB0F058b7LPl7ECODXvi5KDd+JlXWwv7XT0kP2 V+71ab9jaeEiA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 79391240177 for ; Sun, 10 Mar 2024 23:24:31 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 945571601B9; Sun, 10 Mar 2024 23:24:30 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240310192147.GQ6420@pb2> References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> <20240307203739.GI6420@pb2> <170987607651.7287.4766174024309496140@lain.khirnov.net> <20240310033629.GM6420@pb2> <171005119864.662.10837664362214202636@lain.khirnov.net> <20240310192147.GQ6420@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 10 Mar 2024 23:24:30 +0100 Message-ID: <171010947057.7287.8642196154964262055@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-03-10 20:21:47) > On Sun, Mar 10, 2024 at 07:13:18AM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-03-10 04:36:29) > > > On Fri, Mar 08, 2024 at 06:34:36AM +0100, Anton Khirnov wrote: > > > > Quoting Michael Niedermayer (2024-03-07 21:37:39) > > > > > On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote: > > > > > > Treat it analogously to stream parameters like format/dimensions/etc. > > > > > > This is functionally different from previous code in 2 ways: > > > > > > * for non-CFR video, the frame timebase (set by the decoder) is used > > > > > > rather than the demuxer timebase > > > > > > * for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the > > > > > > subtitle decoding API > > > > > > > > > > > > These changes should avoid unnecessary and potentially lossy timestamp > > > > > > conversions from decoder timebase into the demuxer one. > > > > > > > > > > > > Changes the timebases used in sub2video tests. > > > > > > --- > > > > > > fftools/ffmpeg_filter.c | 17 ++- > > > > > > tests/ref/fate/sub2video_basic | 182 +++++++++++++------------- > > > > > > tests/ref/fate/sub2video_time_limited | 8 +- > > > > > > 3 files changed, 106 insertions(+), 101 deletions(-) > > > > > > > > > > breaks: > > > > > > > > > > ./ffmpeg -i \[a-s\]_full_metal_panic_fumoffu_-_01_-_the_man_from_the_south_-_a_hostage_with_no_compromises__rs2_\[1080p_bd-rip\]\[BBB48A25\].mkv -filter_complex '[0:s:1]scale=800:600' -t 15 -qscale 2 -y a.avi > > > > > > > > > > > > > Use a constant framerate. > > > > > > why not automatically choose a supported timebase ? > > > > > > "[mpeg4 @ 0x55973c869f00] timebase 1/1000000 not supported by MPEG 4 standard, the maximum admitted value for the timebase denominator is 65535" > > > > Because I don't want ffmpeg CLI to have codec-specific code for a codec > > that's been obsolete for 15+ years. One could also potentially do it > > inside the encoder itself, but it is nontrivial since the computations > > are spread across a number of places in mpeg4videoenc.c and > > mpegvideo_enc.c. And again, it seems like a waste of time - there is no > > reason to encode mpeg4 today. > > This is not mpeg4 specific, its just a new additional case that fails The case you reported is mpeg4 specific. > ./ffmpeg -i mm-small.mpg test.dv > [dvvideo @ 0x7f868800f100] Found no DV profile for 80x60 yuv420p video. Valid DV profiles are: There is no mechanism for an encoder to export supported time bases. > IMHO ffmpeg should be able to select supported parameters if the user > indicated thats what he wants > > We also do this with pixel formats and not fail and require the user to manually > specify it AFAIK only a tiny number of obsolete encoders place restrictions on the timebase, so I see little point in spending effort on making them work automagically. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".