From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 614F249C52 for ; Tue, 5 Mar 2024 15:19:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA0A168CC0A; Tue, 5 Mar 2024 17:19:32 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC6DB68CC0A for ; Tue, 5 Mar 2024 17:19:25 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=qpyiOvPW; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A7C0024048D for ; Tue, 5 Mar 2024 16:19:25 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 0DstHDDwpmiL for ; Tue, 5 Mar 2024 16:19:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1709651965; bh=kLDT95LTw/AY0I8eZZi9N1wN1U2ZXEbu19jndIAcQ98=; h=Subject:From:To:In-Reply-To:References:Date:From; b=qpyiOvPW2dI3yLr5Uuw/mjfSoOG8Cukf6FgBQHp9es/9BoHOnETKfAbGeL8H4q6TK ykW4Xuz3Xg65M+0v37qqMJ3PluajGXrGJH0WS4TXkurQkDOQiZRmx2DkjcbajqZeng LKgMXvTsvMiDZkAjbgX/gfzsJQ2YO3cQqs+dvDk7AaF/PKfPxl8mr79lWLbgct2ReA uwv3FQnNfJ95XMQOHWSmWxKvI3MQ0WZpAXn1iYiMHbCiARmUMo9r1coQ1cYVNJHZc8 pKrQyvk4HBOxWuTF0y18KeBwNrOWv2HqAhjhGCf2RBGDjJLPPF0LRdE7bA/PMa19dV WpkFvgJQWencg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1856E240177 for ; Tue, 5 Mar 2024 16:19:25 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id E52361601B9; Tue, 5 Mar 2024 16:19:24 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-7-anton@khirnov.net> <6aeedda4-c8a7-4c4c-a33d-d2225508eeeb@gmail.com> <170964899292.29002.12504993650425451482@lain.khirnov.net> <8bf41fe7-a9f9-4ae4-abfc-31117ddae687@gmail.com> <170965045875.29002.15043263301458990476@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 05 Mar 2024 16:19:24 +0100 Message-ID: <170965196491.662.10863422445416192990@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-05 16:07:05) > > > > One possible solution is to rename the option to something like > > side_data_prefer_external (better names welcome), and have it switch > > between user-supplied (i.e. global or per-packet) and in-bitstream side > > data. > > > > This adds an ambiguity for the hypothetical case where some side data > > exists as global and per-packet - then I'd say lavc should default to > > per-packet and leave the other case to the caller (should be very rare, > > possibly could be handled with a bitstream filter). > > If a given side data type at the container level were to be duplicated > in the header (global) and per packet, then IMO the packet must have > priority, given it's the container overriding its own parameters. I'd be careful with 'must' - in a sane world that's what would be reasonable, but I can definitely imagine a situation where you'd want the reverse. But I do agree that it's not something lavc needs to handle. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".